1896100 - 0.14% installer size (OSX) regression on Fri May 3 2024

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Web Codecs, defect, P3)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push a9d9912b02975ff0a979d534b37455ccb122edd0. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.14%	installer size	osx-aarch64-shippable	aarch64 nightly	90,385,412.17 -> 90,514,472.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

You can run these tests on try with ./mach try perf --alert 117

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1894408

Comment 2

[C.M.Chang[:chunmin]]

Hi, thanks for the report. However, the integration of mac/arm64 libvpx code is inevitable from my view. Importing libvpx sources for mac/arm64 is required if Gecko needs a software VPX encoder for WebCodecs on MacOS w/ Apple M* chips. Since WebCodecs is planned to ride on the train at the end of 2024 H1, and the installer size increases by only 0.14%, I don't think it's necessary to find an alternative. Does this make sense to you?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1894408

Comment 4

[Alex Finder]

(In reply to C.M.Chang[:chunmin] from comment #2)

Hi, thanks for the report. However, the integration of mac/arm64 libvpx code is inevitable from my view. Importing libvpx sources for mac/arm64 is required if Gecko needs a software VPX encoder for WebCodecs on MacOS w/ Apple M* chips. Since WebCodecs is planned to ride on the train at the end of 2024 H1, and the installer size increases by only 0.14%, I don't think it's necessary to find an alternative. Does this make sense to you?

Hi chunmin! Thanks for replying and raising the concern here, and I think the installer size increase makes sense given the libvpx video codec library import you mentioned. Please let me know if you decide in the end to close the regression defect as WONTFIX, and I'll update the linked alert summary accordingly. Thanks!

Comment 5

[Haik Aftandilian [:haik]]

I agree we should close this as WONTFIX. The importance of the web codec outweighs the ~130k download increase in size.

Comment 6

[Alex Finder]

(In reply to Haik Aftandilian [:haik] from comment #5)

I agree we should close this as WONTFIX. The importance of the web codec outweighs the ~130k download increase in size.

Thanks for the reply! I closed the alert as won't fix.