1896104 - [wpt-sync] Sync PR 46200 - Fix crash during counters attachment

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46200 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46200
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Fix crash during counters attachment

Counters stack can be empty when we do LeaveElement, instead of DCHECK,
check it in if and just leave function.

DCHECK was hit when there is some li without ol/ul element at first that
create ListOrdinal, but after it in the tree there is another li that
is not sibling or descendant of previous li and doesn't have
ListOrdinal. In this case second li would remove first one during
RemoveStaleCounters, and later would try to remove itself during
RemoveCounterIfAncestorExists, assuming that it created the counter
itself.

Fixed: 339592908, 339641168
Change-Id: I09caa992256bba4e4844b3d0943f6d6c7047f6a1

Reviewed-on: https://chromium-review.googlesource.com/5526739
WPT-Export-Revision: 8428eef5f0e7ccc69722f2a8ec7b088c50ea14c6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ba584598e952654ad73dffae7945b1d46015aad

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/365da962de8d
[wpt PR 46200] - Fix crash during counters attachment, a=testonly

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/365da962de8d