Closed
Bug 1896144
Opened 1 year ago
Closed 1 month ago
nimbus-fml: Network requests don't look at the status code
Categories
(Application Services :: Nimbus SDK, defect)
Application Services
Nimbus SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: beth, Assigned: emcminn)
Details
Attachments
(1 file)
If you attempt to fetch a file that does not exist with single-file, it will try to parse the response as the file content, even though the status code is 404. It should look at the status code and return a more appropriate error.
nimbus-cli fml -- single-file --channel release --ref bogus @mozilla-mobile/firefox-ios/nimbus.fml.yaml test
Error: Problem with https://raw.githubusercontent.com/mozilla-mobile/firefox-ios/bogus/nimbus.fml.yaml: YAML Error: unknown field `404` at line 1 column 4
|
Reporter | |
Updated•4 months ago
|
Flags: needinfo?(brennie)
|
Assignee | |
Updated•2 months ago
|
Assignee: nobody → emcminn
|
|
Reporter | |
Updated•1 month ago
|
Flags: needinfo?(brennie)
|
||
Comment 1•1 month ago
|
||
|
|
||
Comment 2•1 month ago
|
||
Authored by https://github.com/AllegroFox
https://github.com/mozilla/application-services/commit/786cc2273620095455dc7c95020dea158ef42097
[main] bug 1896144 - Throw an error on network request failure
Status: NEW → RESOLVED
Closed: 1 month ago
Flags: qe-verify+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•