1896174 - SeaMonkey session restore is missing the checkboxes in the Classic theme

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Frank-Rainer Grahl (:frg)]

During a session restore the checkmarks are not shown. You can play a guess game unchecking cells. The gif icons are only available for macOS starting with 56a1 so all 2.53 versions are affected.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1896174-checkbox-25319.patch

Uses the copied and converted macOS gifs.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1896174-checkbox-svg-25319.patch

Tried the svg images and I can't say I like them 1:1. I would prefer using them but they seem to big. So would need additional styling. Patch on top of the first one.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9401157 [details] [diff] [review]
1896174-checkbox-svg-25319.patch

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: missing functionlity
Testing completed (on m-c, etc.): 2.53.19b1pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 4

[Ian Neal]

Comment on attachment 9401154 [details] [diff] [review]
1896174-checkbox-25319.patch

[Triage Comment]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cf8dcc246c8e
Restore missing checkbox icons in classic theme. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c6c9bf6c3ce6c5f1271d4e1fefc3488c974a473c
Restore missing checkbox icons in classic theme. r=IanN a=IanN