1896193 - Add telemetry for how long it takes Glean to write to disk

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

In https://share.firefox.dev/3WUbWrp we see Glean spending 2.1s doing serialization/writing to disk. It would probably be good to get a sense how bad this is in the real world.

Comment 1

[Travis Long [:travis_]]

Jan-Erik, is this something you could do along with the other things in your Glean-perf work?

Comment 2

[Jan-Erik Rediger [:janerik]]

Not immediately, but yes.

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: [mozilla/glean] Bug 1896193 - Collect samples of Rkv commit timing (#2845)

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: data-review.txt

Comment 5

[Travis Long [:travis_]]

Comment on attachment 9411971 [details]
data-review.txt

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored by [e-mail]

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical information

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 6

[Jan-Erik Rediger [:janerik]]

badboy merged PR [mozilla/glean]: Bug 1896193 - Collect samples of Rkv commit timing (#2845) in 3cfd129.