1896194 - [wpt-sync] Sync PR 46205 - Move page margin handling over to Blink.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46205 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46205
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Move page margin handling over to Blink.

Remove the margin handling code from PrintRenderFrameHelper (used by the
actual browser) and SpoolPagesWithBoundariesForTesting() (web tests).

This allows @page backgrounds to cover the entire page box, including
the margin area. Tests included.

This CL also paves the road for implementing @page margin boxes (such as
author-specified headers and footers), which was the main objective
anyway.

The fact that Blink is now responsible for the entire page box means
that the code that deals with shrinking / centering paginated content to
fit the target paper also has to be moved over to Blink.

WebPrintPageDescription still provides margin info for each page.
Although PrintRenderFrameHelper no longer needs to position the page
area within the page box based on margins, the margins are still needed
in order to figure out if there's enough room for UA-generated headers
and footers.

By moving all of this into Blink, it will be rather straight-forward to
add web tests for page fitting, rather than writing clunky
PrintRenderFrameHelper component browser tests for it. Will follow up
with a CL for this.

Three page-orientation tests now start passing. The code in
SpoolPagesWithBoundariesForTesting() didn't add margin translation at
the correct time when rotating. The margins are no longer added there,
so the problem is gone.

Bug: 40286153, 40341678
Change-Id: I418b2e08ed76b297ea5d5fc223545b52b3e9b09f
Reviewed-on: https://chromium-review.googlesource.com/5526464
WPT-Export-Revision: c187830b21f188ce2ec49f356718e4d214728085

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9533fe1dd07a69ffe25061990372a4bb687c6164

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-page/page-box-005-print.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/css-page/page-box-006-print.html [wpt.fyi]: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b43e695dd7bf
[wpt PR 46205] - Move page margin handling over to Blink., a=testonly
https://hg.mozilla.org/integration/autoland/rev/8539c1ac01b6
[wpt PR 46205] - Update wpt metadata, a=testonly

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/b43e695dd7bf
https://hg.mozilla.org/mozilla-central/rev/8539c1ac01b6