1896243 - [wpt-sync] Sync PR 46217 - Reland "webnn: Enforce input data type constraints for gather indices"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46217 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46217
Details from upstream follow.

lisa0314 <[e-mail]> wrote:

Reland "webnn: Enforce input data type constraints for gather indices"

This is a reland of commit ef29e11bfb1f1f4eae0935fb58f0e4129620837b

Original change's description:

webnn: Enforce input data type constraints for gather indices

As specified in https://github.com/webmachinelearning/webnn/pull/646

Bug: 328567884
Change-Id: I33eba7e1def430b1cb94e3e7a4868e82c5bbd9a3
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5520313
Reviewed-by: Austin Sullivan \<[e-mail]>
Commit-Queue: Lisha Guo \<[e-mail]>
Reviewed-by: ningxin hu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1298443}

Bug: 328567884
Change-Id: Ide6a0e1bc6d3ebea7dce6bf37da4318e7b6e1bd1
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel

Reviewed-on: https://chromium-review.googlesource.com/5532907
WPT-Export-Revision: 7dc04ba4f53067d4ecacc76cfc59261837c64c99

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 46217 applied with additional changes from upstream: d6d0be238786b4d3c3e9cfe29fc8ce1ba485fda3, 431f8d35685a7c4d1e128e13b63e093cef5da6ba, 7852cad3da27ae7235ef50575ac85a0880141da9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f995bc35fcad2f1dbb9da2243fb5c4bb1663c81

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 11 subtests

Status Summary

Firefox

OK : 2
FAIL: 22

Chrome

OK : 2
PASS: 22

Safari

OK : 2
FAIL: 22

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webnn/validation_tests/gather.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with default options and 0-D indices: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with axis = 2: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with indices's dataType = uint32: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with indices's dataType = int32: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the input is a scalar: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the axis is greater than the rank of input: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the data type of indices is float32 which is invalid: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the data type of indices is uint64 which is invalid: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if indices is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/validation_tests/gather.https.any.worker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with default options and 0-D indices: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with axis = 2: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with indices's dataType = uint32: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with indices's dataType = int32: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the input is a scalar: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the axis is greater than the rank of input: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the data type of indices is float32 which is invalid: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the data type of indices is uint64 which is invalid: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if indices is from another builder: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /webnn/validation_tests/gather.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
• /webnn/validation_tests/gather.https.any.worker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd545c89b7b7
[wpt PR 46217] - Reland "webnn: Enforce input data type constraints for gather indices", a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dd545c89b7b7