Closed Bug 1896260 Opened 6 months ago Closed 5 months ago

[toolbar redesign] add or update experiment feature name to navbar experiment

Categories

(Fenix :: Toolbar, task, P2)

All
Android
task

Tracking

(firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: royang, Assigned: royang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(1 file)

Currently the Nimbus experiment flag is named toolbar redesign. Add or update the current experiment flag to be used for navbar experiment.

Severity: -- → N/A
Whiteboard: [fxdroid]
Priority: -- → P2

We will need to update the Experimenter ticket's targeting JSON.

The Beta Experimenter ticket: https://experimenter.services.mozilla.com/nimbus/android-toolbar-redesign/summary

Assignee: nobody → royang
Attachment #9407095 - Attachment description: WIP: Bug 1896260 - Update settings and Nimbus feature name for navigation toolbar → Bug 1896260 - Update settings and Nimbus feature name for navigation toolbar
Pushed by royang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3f50ef1be81 Update settings and Nimbus feature name for navigation toolbar r=android-reviewers,skhan

Backed out for causing fenix failures in BaseBrowserFragmentTest.kt

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/BaseBrowserFragmentTest.kt:89:26: error: Unresolved reference: enableIncompleteToolbarRedesign
Flags: needinfo?(royang)
Attachment #9407095 - Attachment description: Bug 1896260 - Update settings and Nimbus feature name for navigation toolbar → Bug 1896260 - Update settings and Nimbus feature name for navigation toolbar r=skhan
Pushed by royang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76b75d61ff70 Update settings and Nimbus feature name for navigation toolbar r=android-reviewers,skhan

Thanks for backing it out for me. Unfortunately there was a change that landed in autoland today conflicted with my change.
I've updated against the autoland and fixed the conflict. I've landed it again.

Flags: needinfo?(royang)
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: