1896265 - Re-integrate observation of events that should update the Top Sites component

Status: RESOLVED FIXED

(Firefox :: Top Sites, task, P2)

Description

[James Teow [:jteow]]

Even though onAction is essentially no-op and could be removed entirely, it might make more replace ones that can subscribe to changes without requiring the New Tab store to alert it (e.g. preference changes), and leave the actions that will need replacing by touching New Tab code.

Comment 1

[James Teow [:jteow]]

To be specific, the Top Sites component should update its internal state under the following conditions:

• A change occurs in Places.
• A dependent preference changes state or has its initial values set.
• Top Sites has a pinned/unpinned site.
• A new top site is inserted.
• A pinned search shortcut needs to be updated.

Some investigation should be done to see if we also need to carry over:

• Initialization
• Un-initialization
• System tick

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 1: Listen to Places events - r?dao!

Comment 3

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 2: Force consumers to call TopSites.pin and TopSites.unpin directly - r?dao!

Depends on D211417

Comment 4

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 3: Force consumers to use TopSites.insert - r?dao!

Depends on D211418

Comment 5

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 4: Rely on TopSites.updatePinnedSearchShortcuts to update search shortcuts - r?dao!

Depends on D211419

Comment 6

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 5: Change main entry points to update search shortcuts and remove init/uninit from onActions - r?dao!

Depends on D211420

Comment 7

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 6: Subscribe to all relevant preference changes - r?dao!

Depends on D211421

Comment 8

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 7: Remove periodic updates of TopSites - r?dao!

Depends on D211422

Comment 9

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 8: Remove initial preference values event - r?dao!

Depends on D211423

Comment 10

[James Teow [:jteow]]

Attachment: Bug 1896265 - Part 9: Expire link caches on un-initialization - r?dao!

It's mostly helpful for browser tests to reset TopSites.

Depends on D211424

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/256e6601fd8c
Part 1: Listen to Places events - r=dao
https://hg.mozilla.org/integration/autoland/rev/4f017b452f96
Part 2: Force consumers to call TopSites.pin and TopSites.unpin directly - r=dao
https://hg.mozilla.org/integration/autoland/rev/d72d56a01f45
Part 3: Force consumers to use TopSites.insert - r=dao
https://hg.mozilla.org/integration/autoland/rev/412b814bf7bb
Part 4: Rely on TopSites.updatePinnedSearchShortcuts to update search shortcuts - r=dao
https://hg.mozilla.org/integration/autoland/rev/4d3e8de49e3b
Part 5: Change main entry points to update search shortcuts and remove init/uninit from onActions - r=dao
https://hg.mozilla.org/integration/autoland/rev/88ad64c18ce2
Part 6: Subscribe to all relevant preference changes - r=dao
https://hg.mozilla.org/integration/autoland/rev/1a8aabb26f46
Part 7: Remove periodic updates of TopSites - r=dao
https://hg.mozilla.org/integration/autoland/rev/62cd841e0d90
Part 8: Remove initial preference values event - r=dao
https://hg.mozilla.org/integration/autoland/rev/1742a6a7f0f6
Part 9: Expire link caches on un-initialization - r=dao

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/256e6601fd8c
https://hg.mozilla.org/mozilla-central/rev/4f017b452f96
https://hg.mozilla.org/mozilla-central/rev/d72d56a01f45
https://hg.mozilla.org/mozilla-central/rev/412b814bf7bb
https://hg.mozilla.org/mozilla-central/rev/4d3e8de49e3b
https://hg.mozilla.org/mozilla-central/rev/88ad64c18ce2
https://hg.mozilla.org/mozilla-central/rev/1a8aabb26f46
https://hg.mozilla.org/mozilla-central/rev/62cd841e0d90
https://hg.mozilla.org/mozilla-central/rev/1742a6a7f0f6