1896310 - Attached images are not displayed inline when the bug has no keywords

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Bug Creation/Editing, defect)

Description

[chrizilla]

Sometimes attached images are displayed (inline) in comments.
Sometimes they aren't.

On what does it depend? Is this a bug?

Note that I never selected the option below, so this does not explain the inconsistency:

If the attachment is not suitable for preview in the browser, check the box below:
[   ] hide preview

Comment 1

[chrizilla]

Attachment: test

test to see if image is displayed

result: image not displayed

Comment 2

[Andre Klapper]

Hi, feel free to ask general questions how things work in support forums. Mozilla Bugzilla is for bug reports and feature requests. Thanks!

Sometimes attached images are displayed.

I don't think so.

Comment 3

[David Lawrence [:dkl]]

(In reply to chrizilla from comment #1)

Created attachment 9401326 [details]
test

test to see if image is displayed

result: image not displayed

when clicking on the link for the attachment in the comment, I am able to see a window display image from the attachment. So it seems to be working properly for me as well.

Comment 4

[chrizilla]

(In reply to David Lawrence [:dkl] from comment #3)

when clicking on the link for the attachment in the comment

You are referring to the pop-up overlay that appears when you click on an attachment link.
That's not what I am referring to. I reworded comment #0 for clarification.
This bug is about images being displayed inline in the comments:

• Sometimes attached images are displayed as images in comments (inline, automatically, i.e. without clicking anywhere).
• Sometimes attached images are NOT displayed inline, but only as a link which has to be clicked.

Comment 5

[chrizilla]

(In reply to Andre Klapper from comment #2)

Sometimes attached images are displayed.

I don't think so.

You are wrong here. Log into your BMO account, go to preferences > general preferences > user interface.
You will find a setting show attachments inline which is ON by site default.

Attached images are often displayed inline. I am seeing this regularly. Unfortunately not always.
As proof, in the 2 subsequent comments below, you can see:

• 1 screenshot of image attachment displayed inline and
• 1 screenshot of image attachment not displayed inline (only shown as link)

Mozilla Bugzilla is for bug reports

Yes, this is a bug report. Where are forums for BMO btw ?

Comment 6

[chrizilla]

Attachment: screenshot of image attachment - displayed as link only.png

screenshot: image attachment displayed as link only
source: screenshot captured from bug1896310#comment1

Comment 7

[chrizilla]

Attachment: screenshot of image attachment - displayed inline.png

screenshot: image attachment displayed inline
source: screenshot captured from bug1896309#comment1

Comment 8

[:glob ✱]

Thanks, specific examples help. Here's a rephrasing of the issue:

https://bugzilla.mozilla.org/show_bug.cgi?id=1896309#c1 shows the attached image inline in the activity stream.

https://bugzilla.mozilla.org/show_bug.cgi?id=1896310#c1 has an attachment image, yet it is not displayed inline.

Comment 9

[chrizilla]

@:glob : thank you for your help. Added link to your comment.

Comment 10

[chrizilla]

Thank you for your help/rewording.

I just realized that BMO's behaviour is not consistent:
– Yesterday the image in this comment was displayed as a link only.
– Today the same image is displayed inline as an image.

Comment 11

[chrizilla]

Maybe this helps with figuring out what's going on:

• 15 minutes ago I viewed bug 1845337 and the attached images there were not displayed inline but only as links.
• Now, 15 minutes later, I visited bug 1845337 again and all attached images are displayed inline.

I did not change any settings in the meanwhile, so the problem does not seem to be on the user side.

Comment 12

[David Lawrence [:dkl]]

What i feel like is happening here is that since we now store attachments over a certain size in cloud storage (GCP) instead of in the DB directly, there is a timing or simply a size issue. Size meaning that attachments under the threshold f 20k which are stored in the DB will display inline. And timing meaning that if an attachment does not return from cloud storage quick enough then it will not display inline. So that would explain the intermittent nature of this issue. I will need to take some time to see what can be done to make this consistently work.

Comment 13

[Kohei Yoshino [:kohei]]

Artem Manushenkov brought this issue to my attention on Matrix. Look at the code, it seems to be a regression from my change in Bug 1549621. I don’t remember why I added this bug_keywords check but it’s unnecessary. I’ll remove it.

Comment 14

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1896310 - Attached images are not displayed inline unless bug has any keywords (#2476)

Comment 15

[Kohei Yoshino [:kohei]]

All images in the previous comments are now displayed because the bug has the regression keyword.

Comment 16

[BMO Github Automation]

Authored by https://github.com/kyoshino
https://github.com/mozilla-bteam/bmo/commit/ae5f280217f2a07295c3d84eb08b7f6fa3d1b35c
[master] Bug 1896310 - Attached images are not displayed inline when the bug has no keywords