Re-enable puppeteer test network Page.authenticate should allow disable authentication (network.spec.js)
Categories
(Remote Protocol :: WebDriver BiDi, task, P3)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Unassigned)
References
Details
(Whiteboard: [webdriver:backlog])
The test is currently marked as FAIL/PASS because it depends on the value of network.auth.use_redirect_for_retries which changes depending on the channel.
We should reenable the test everywhere once the preference is true on all channels.
Sunil: you mentioned that you planned to roll out this change soon, before next ESR, but is there already a bug to track this? Since we marked the test as PASS/FAIL, we won't really know when the preference has changed so it would be handy to have a bug to use as a blocker.
|
||
Comment 1•5 months ago
|
||
Julian, we will enable it by default with Bug 1896350.
|
|
||
Updated•5 months ago
|
|
Reporter | |
Updated•5 months ago
|
|
||
Comment 3•4 months ago
|
||
Given that the test is still failing I assume we need more fixes. The message for the expectation is: `"The Puppeteer implementation does not expect 2 responseCompleted events (that AuthRequired triggered)".
|
|
Reporter | |
Comment 4•4 months ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #3)
Given that the test is still failing I assume we need more fixes. The message for the expectation is: `"The Puppeteer implementation does not expect 2 responseCompleted events (that AuthRequired triggered)".
With Bug 1896350 addressed, we can now switch back the test status to always FAIL.
So we could already land that here.
Changing the test to PASS will require Bug 1899604, or an update to Puppeteer to handle the fact that all authentication attempts have the same request id (see https://github.com/w3c/webdriver-bidi/issues/722)
|
|
||
Comment 5•4 months ago
|
||
Note that the test is already marked as always fail. Does it mean we can close this bug given that the status will be updated with the patch on bug 1899604?
|
|
Reporter | |
Comment 6•4 months ago
|
||
Indeed it was switched back to FAIL in latest sync anyway (Bug 1897183). Interesting to note that it wasn't picked up by late beta sims? I checked a few and it seems the puppeteer jobs didn't run there.
I think we can close this bug given that Bug 1899604 already has all the information for what remains to be fixed here.
Description
•