1896374 - remove firefox snap repackage taskcluster execution

Status: RESOLVED FIXED

(Firefox Build System :: Third Party Packaging, task)

Comment 1

[:gerard-majax]

this broke in https://bugzilla.mozilla.org/show_bug.cgi?id=1895338 and the yaml definition is now severely outdated. per https://bugzilla.mozilla.org/show_bug.cgi?id=1895338#c7 there's no use, i think jed would be the sole user via mach repackage snap

Comment 2

[Johan Lorenzo [:jlorenzo]]

This is fine by me. I confirm this has little use. I defer to :jld regarding his usage.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

We should get rid of this task. I agree with the reasons in bug 1895338 comment #2; in addition, the code that tries to install snaps without snapd seems like… not something we'd want to maintain if we can avoid it.

The mach repackage snap patches never landed; I got some review feedback a while ago and haven't had time to revisit them. So, if I need to figure something else out in terms of how to generate a snapcraft.yaml file to do the repackaging, I can do that the next time I look at those patches.

Comment 4

[:gerard-majax]

Attachment: Bug 1896374 - Remove release-snap-repackage task r?#releng!

Comment 5

[:gerard-majax]

https://treeherder.mozilla.org/jobs?repo=try&revision=d18f4998c2467004a95b6fa1b33b9d97ec35e834

Comment 6

[:gerard-majax]

and now i realize upstream depends on it :p https://github.com/canonical/firefox-snap/blob/stable/snapcraft.yaml#L410

Comment 7

[:gerard-majax]

Martin, Johan, do you think we could rather use the one provided in https://searchfox.org/mozilla-central/source/browser/components/shell/search-provider-files/firefox.desktop ?

The most important differences are translations, a few names of categories that the Snap one has and this one does no, but they serve the same purpose otherwise.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to :gerard-majax from comment #7)

Martin, Johan, do you think we could rather use the one provided in https://searchfox.org/mozilla-central/source/browser/components/shell/search-provider-files/firefox.desktop ?

The most important differences are translations, a few names of categories that the Snap one has and this one does no, but they serve the same purpose otherwise.

Yes, it'd use the one. But you need to flip DBusActivatable to false as you perhaps don't ship Firefox DBus service.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Agreed. I'm okay to merge taskcluster/docker/firefox-snap/firefox.desktop into browser/components/shell/search-provider-files/firefox.desktop

Comment 10

[:gerard-majax]

Amin, would you be fine if we removed taskcluster/docker/firefox-snap/firefox.desktop file and rather rely on DesktopFileTransform from https://phabricator.services.mozilla.com/D210807 to generate it?

You'd need to update the build step to include something like:

from mozbuild.repackaging.snapcraft_transform import DesktopFileTransform
source_desktop = os.path.join(srcdir, "browser/components/shell/search-provider-files/firefox.desktop")
with open(os.path.join(snapdir, "firefox.desktop"), "w") as desktop_file:
    desktop_file.write(
        DesktopFileTransform(source_desktop, icon="default256.png").repack()
    )

Which can be invoked via mach python

Comment 11

[Amin Bandali [:bandali]]

As long as the upstream snap use-case is covered (which per what you said it very well would be, via DesktopFileTransform) then sure, it's fine by me.

Just to clarify for myself, is mach python a proper wrapper around the Python interpreter, so I could pass the above snippet to its standard input or with -c as a literal string or an actual file? (Asking to make sure this new step could be done fully non-interactively during Firefox snap build.)

Comment 12

[:gerard-majax]

Yes

Comment 13

[:gerard-majax]

Attachment: Bug 1896374 - Remove firefox-snap docker image r?#releng!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1163b1b4b0a
Remove release-snap-repackage task r=releng-reviewers,taskgraph-reviewers,jcristau

Comment 15

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/f1163b1b4b0a

Comment 16

[:gerard-majax]

Looks like we need keep open even when there are two patches ?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fdd37f88130
Remove firefox-snap docker image r=releng-reviewers,bhearsum

Comment 18

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/9fdd37f88130

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.