1896475 - Implement Request/Response `.bytes()` method

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P2)

Description

[bakkot]

Steps to reproduce:

See https://github.com/whatwg/fetch/issues/1732.

Tests at https://github.com/web-platform-tests/wpt/pull/46198.

The above spec PR adds a bytes() method to get a Uint8Array to Body, instead of requiring users to get an ArrayBuffer with arrayBuffer() and then wrap it.

There are also PRs to do the same for Blob and PushMessageData, which copy relevant parts of the Body interface:

• https://github.com/w3c/FileAPI/pull/197
• https://github.com/w3c/push-api/pull/369

Comment 1

[Tom S [:evilpie]]

Sounds interesting, I will have a look.

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1896475 - Make BodyConsumer::ConsumeType an enum class. r?saschanaz

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1896475 - Implement Request/Response `.bytes()` method. r?saschanaz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9d4c74f4162
Make BodyConsumer::ConsumeType an enum class. r=saschanaz
https://hg.mozilla.org/integration/autoland/rev/deb6dfcd6d8c
Implement Request/Response `.bytes()` method. r=saschanaz,webidl

Comment 5

[Iulian Moraru]

Backed out for causing assertions on Interpreter.cpp.

• Push with failures

• Failure log

• Backout link

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46444 for changes under testing/web-platform/tests

Comment 7

[Cosmin Sabou [:CosminS]]

Also these mochitest plain test failures: https://treeherder.mozilla.org/logviewer?job_id=459245382&repo=autoland&lineNumber=2773

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66113edf97b9
Make BodyConsumer::ConsumeType an enum class. r=saschanaz
https://hg.mozilla.org/integration/autoland/rev/05cad689932f
Implement Request/Response `.bytes()` method. r=saschanaz,webidl

Comment 10

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/66113edf97b9
https://hg.mozilla.org/mozilla-central/rev/05cad689932f

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Is this worth an Fx128 relnote?

Comment 13

[Tom S [:evilpie]]

Seems a bit minor for a relnote.

Comment 14

[Tom S [:evilpie]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New convenience function on many objects
[Affects Firefox for Android]: yes
[Suggested wording]: A new methods bytes() is provided on many objects like Request/Response and Blob that provides a convenient way of getting an Uint8Array typed array.
[Links (documentation, blog post, etc)]: Not yet really? https://github.com/w3ctag/design-principles/issues/463

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx128 relnotes.

Comment 16

[Hamish Willee]

FF128 MDN docs for this covered in https://github.com/mdn/content/issues/33984