1896494 - Formautofill doesn't always capture the newest data for split fields

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Issam Mani [:issammani]]

0. Go to: https://codepen.io/issammani/pen/PovoQMq
1. Autofill a credit card
2. Change either one of the cc-name-* fields and/or the cc-exp
3. Submit

Expected behaviour

Doorhanger shows to update the credit card data

Current behaviour

Doorhanger doesn't show up.

Comment 1

[Issam Mani [:issammani]]

This the form from the codepen:

<form>
<input autocomplete="cc-given-name" />
<input autocomplete="cc-additional-name" />
<input autocomplete="cc-family-name" />
<input autocomplete="cc-name" hidden/>
<input autocomplete="cc-number" />
<input autocomplete="cc-exp" />
<input autocomplete="cc-exp-month" hidden/>
<input autocomplete="cc-exp-year" hidden/>

<input type="submit" />
</form>

What happens is that we autofill hidden fields ( for a good reason ), but when we capture we have no logic to check which fields were changed in the case of split fields. For name, we always prefer the cc-name field and for expiration date we prefer the split fields. This causes us to not pickup changes from the form.