1896538 - Explicitly check supported codec in FFmpegEncoderModule

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Description

[C.M.Chang[:chunmin]]

FFmpegEncoderModule<V>::Supports has two problems:

1. SupportsCodec(aConfig.mCodec) != AV_CODEC_ID_NONE doesn't make sense. The SupportsCodec return a bool, so it shouldn't be compared with AV_CODEC_ID_NONE
2. Even if GetFFmpegEncoderCodecId finds a AVCodecID, it doesn't guarantee we have the underlying encoder. We should query the underlying codec like what FFmpegDecoderModule does

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1896538 - Remove unnecessary comparison in FFmpegEncoderModule::Supports

The SupportsCodec returns a bool, so it shouldn't be compared with
AV_CODEC_ID_NONE.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1896538 - Enhance FFmpegEncoderModule's SupportsCodec check

This patch enhances the SupportsCodec function by explicitly verifying
the supported encoder within the FFmpegEncoderModule. Previously, the
function checked whether the CodecType could be mapped to an AVCodecID,
but this alone didn't guarantee the existence of the corresponding
encoder. Now, the patch ensures the existence of the encoder by directly
checking for it within the FFmpegEncoderModule.

Depends on D210251

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e7b5608cab3
Remove unnecessary comparison in FFmpegEncoderModule::Supports r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/166e08b48e06
Enhance FFmpegEncoderModule's SupportsCodec check r=media-playback-reviewers,padenot

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0e7b5608cab3
https://hg.mozilla.org/mozilla-central/rev/166e08b48e06