Closed Bug 1896593 Opened 1 year ago Closed 1 year ago

Make our refresh driver tick match the HTML spec more closely.

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

This doesn't change behavior intentionally, though it annotates places
where our code doesn't match the spec right now, and adds comments and
quotes the HTML spec in the relevant places.

Some things that this highlights:

  • Resize steps are fired at the wrong time.
  • Some of our animation stuff seems sketchy / out of place too to me
    (AnimationTimeline observes the refresh driver at the style phase).
  • Focus fix-up is out of order (that's known, bug 1788741 for tests).
  • Our layout flush stuff should probably be better integrated / closer
    to the resize observer loop.
  • Display observers are run before stuff like ResizeObserver runs. That
    might be a problem for accessibility's NotificationController?

Again, these are intentionally not addressed in this patch.

Blocks: 1896760
Blocks: 1896762
Blocks: 1896763
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e88bed5f3358 Make our refresh driver tick match the HTML spec more closely. r=smaug
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Regressions: 1897329
Regressions: 1897322
Regressions: 1897571
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: