Closed Bug 1896609 Opened 1 year ago Closed 11 months ago

FOG: Memory reporter for all generated metrics

Categories

(Data Platform and Tools :: Glean: SDK, task, P1)

task

Tracking

(firefox140 fixed)

RESOLVED FIXED
Tracking Status
firefox140 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Split of bug 1805996.
Measuring the memory usage of all metrics is a bit ... complex.
The straight-forward way of calling size_of on every metric object leads to generating a function that is in the top 30 of largest functions. We might need to rethink how to do that.

This requires a Glean update that implements all that malloc_size_of.

Current downside:
The generated fog_metric_alloc_size is the 30th largest function in an
optimized build.
It's some 3000 lines long, because it has to call size_of on each and
every metric (majority of them use counters).
This will only grow with the number of metrics we add. I don't have a
solution for that yet.

Depends on D210288

Assignee: jrediger → nobody
Priority: P2 → P3
Assignee: nobody → jrediger
Priority: P3 → P1
Attachment #9401630 - Attachment description: WIP: Bug 1896609 - FOG: Report memory size of all metrics r?chutten! → WIP: Bug 1896609 - FOG: Report memory size of all (instantiated) metrics r?chutten!
Attachment #9401630 - Attachment description: WIP: Bug 1896609 - FOG: Report memory size of all (instantiated) metrics r?chutten! → Bug 1896609 - FOG: Report memory size of all (instantiated) metrics r?chutten!
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc4228c45495 FOG: Report memory size of all (instantiated) metrics r=chutten
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Regressions: 1965747
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: