1896681 - Home and newtab weather widget locale/region controls

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

Do we want the system pref to be behind some sort of locale/region logic, so we can control what regions have this feature as an option?

This is currently the pattern we use for spocs and pocket stories.

Nimbus can target locale/region, but Firefox cannot. So once we go past Nimbus and start turning this on in trains, do we want the ability to control what regions see this or turn it on globally?

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: We intend to launch a weather experiment in 127. It should be a low risk, small set of changes.

The weather experiment is going to be US only. The weather response accuracy in other regions can be less accurate, so until we do more testing in other regions, we want to keep this feature behind a US only flag.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox127 (beta). However, the bug still isn't assigned.

:amy, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1896681 - Home and newtab adding region control for weather widget

Comment 4

[Scott [:thecount] Downe]

Attachment: Bug 1896681 - Home and newtab weather widget region config control

Comment 5

[Scott [:thecount] Downe]

Steps to test:

1. Set "browser.newtabpage.activity-stream.discoverystream.region-weather-config" to "CA", where "CA" matches what's in "browser.search.region"
   Note: "browser.newtabpage.activity-stream.discoverystream.region-weather-config" can be a comma separated list of region, example: "CA,US", and this would enable weather for multiple regions.
2. Restart newtab.
3. Open newtab
   Expected: Should see weather. If your region pref did not match what was in region-weather-config, and you restart, you should not see weather.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/268ec5298013
Home and newtab adding region control for weather widget r=home-newtab-reviewers,amy

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/268ec5298013

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Is the experiment nightly-only for now? ie not intending to ship with 127? If not then we can set the firefox127 flag to disabled. But if this is for 127 then please request uplift. Thanks!

Comment 9

[Scott [:thecount] Downe]

Attachment: Bug 1896681 - Home and newtab adding region control for weather widget

Original Revision: https://phabricator.services.mozilla.com/D211146

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: This impacts an experiment we plan to run in 127
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: 1. Set "browser.newtabpage.activity-stream.discoverystream.region-weather-config" to "CA", where "CA" matches what's in "browser.search.region" Note: "browser.newtabpage.activity-stream.discoverystream.region-weather-config" can be a comma separated list of region, example: "CA,US", and this would enable weather for multiple regions. 2. Restart newtab. 3. Open newtab Expected: Should see weather. If your region pref did not match what was in region-weather-config, and you restart, you should not see weather.
• Risk associated with taking this patch: Low
• Explanation of risk level: It's a single new pref and a single function to set the pref, based off an existing pattern.
• String changes made/needed: None
• Is Android affected?: no

Comment 11

[Scott [:thecount] Downe]

Uplift request is in.

Comment 12

[Alice Varro [avarro], Ecosystem QA]

I have verified this enhancement using Firefox Nightly 128.0a1, Build ID: 20240526212755 and Firefox Beta 127.0b7 (build downloaded from Treeherder), Build ID: 20240526171419 and I can confirm that the Weather Widget is successfully displayed when the "browser.newtabpage.activity-stream.discoverystream.region-weather-config" matches the "browser.search.region" pref while the Weather widget is not displayed on the New Tab page when the value of the prefs do not match.