1896709 - Implement initial prototype of the on-memory cache of JS::Stencil based on SharedSubResourceCache behind a pref

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Tooru Fujisawa [:arai]]

Bug 1729488 added mozilla::SharedSubResourceCache, which can be used also by JS to cache the compiled stencil across documents and navigation.

This can reduce the cost of IPC as long as the cache doesn't expire, and also make it possible to cache more eagerly.

bug 1879123 can be a further optimization after this, to reduce the cost of IPC when the cache expires but the server returns the same data.

Comment 1

[Tooru Fujisawa [:arai]]

Given there are multiple tasks necessary before enabling the navigation cache, let's land the initial prototype behind a pref,
so that other tasks can be done based on this concurrently.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 1: Add const variant of LoadContextBase::AsWindowContext. r?nbp!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 2: Add const variant of ScriptLoadRequest::GetScriptLoadContext. r?nbp!

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 3: Add LoadedScript::CanHaveBytecode. r?nbp!

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 4: Accumulate cache expiration time in script load. r?nbp!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 5: Add ScriptLoadRequest::IsCacheable. r?nbp!

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 6: Add JSExecutionContext::{SetKeepStencil,StealStencil}. r?nbp!

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 7: Add pref for nagivation cache. r?nbp!

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 8: Add Stencil variant to LoadedScript. r?nbp!

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 9: Add ScriptLoadRequest::CacheEntryFound. r?nbp!

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 10: Add SharedScriptCache. r?nbp!

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 11: Add PContent::ClearScriptCache. r?nbp!

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 12: Add SharedScriptCache field to ScriptLoader. r?nbp!

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 13: Use SharedSubResourceCache in ScriptLoader. r?nbp!

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 14: Add ChromeUtils.clearScriptCache* methods. r?nbp!

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 15: Add nsIDOMWindowUtils.clearSharedScriptCache. r?nbp!

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 16: Integrate into nsIClearDataService. r?nbp!

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1896709 - Part 17: Add tests. r?nbp!

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89c4c6bb465a
Part 1: Add const variant of LoadContextBase::AsWindowContext. r=nbp
https://hg.mozilla.org/integration/autoland/rev/50b0f6a23e3c
Part 2: Add const variant of ScriptLoadRequest::GetScriptLoadContext. r=nbp
https://hg.mozilla.org/integration/autoland/rev/34fc79dc1ad7
Part 3: Add LoadedScript::CanHaveBytecode. r=nbp
https://hg.mozilla.org/integration/autoland/rev/52ce0ebfb29a
Part 4: Accumulate cache expiration time in script load. r=nbp
https://hg.mozilla.org/integration/autoland/rev/220b544127cb
Part 5: Add ScriptLoadRequest::IsCacheable. r=nbp
https://hg.mozilla.org/integration/autoland/rev/54eea04a7342
Part 6: Add JSExecutionContext::{SetKeepStencil,StealStencil}. r=nbp
https://hg.mozilla.org/integration/autoland/rev/842f2047a4bd
Part 7: Add pref for nagivation cache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/e8615b5d82ab
Part 8: Add Stencil variant to LoadedScript. r=nbp
https://hg.mozilla.org/integration/autoland/rev/6c9338852a19
Part 9: Add ScriptLoadRequest::CacheEntryFound. r=nbp
https://hg.mozilla.org/integration/autoland/rev/20ff83806cc6
Part 10: Add SharedScriptCache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/8ca8a4082e44
Part 11: Add PContent::ClearScriptCache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c6878c5fdde4
Part 12: Add SharedScriptCache field to ScriptLoader. r=nbp
https://hg.mozilla.org/integration/autoland/rev/b7bcb9904435
Part 13: Use SharedSubResourceCache in ScriptLoader. r=nbp
https://hg.mozilla.org/integration/autoland/rev/6fa3424dfc40
Part 14: Add ChromeUtils.clearScriptCache* methods. r=nbp
https://hg.mozilla.org/integration/autoland/rev/26fac760de19
Part 15: Add nsIDOMWindowUtils.clearSharedScriptCache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/0271e50308e6
Part 16: Integrate into nsIClearDataService. r=nbp,extension-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/046f0f522ce7
Part 17: Add tests. r=nbp

Comment 20

[Norisz Fay [:noriszfay]]

Backed out for causing build bustage and mochitest failures

Backout link

Push with failures

Failure log - bustage
Failure log - mochitest

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c37eaabbc74
Part 1: Add const variant of LoadContextBase::AsWindowContext. r=nbp
https://hg.mozilla.org/integration/autoland/rev/3bdc257459a7
Part 2: Add const variant of ScriptLoadRequest::GetScriptLoadContext. r=nbp
https://hg.mozilla.org/integration/autoland/rev/3de0c9879853
Part 3: Add LoadedScript::CanHaveBytecode. r=nbp
https://hg.mozilla.org/integration/autoland/rev/612ca40ba579
Part 4: Accumulate cache expiration time in script load. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c0f31a4239be
Part 5: Add ScriptLoadRequest::IsCacheable. r=nbp
https://hg.mozilla.org/integration/autoland/rev/6ec335dbf1e6
Part 6: Add JSExecutionContext::{SetKeepStencil,StealStencil}. r=nbp
https://hg.mozilla.org/integration/autoland/rev/30f926126ce2
Part 7: Add pref for nagivation cache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/674b0b86b1d4
Part 8: Add Stencil variant to LoadedScript. r=nbp
https://hg.mozilla.org/integration/autoland/rev/91e9ae3ba36b
Part 9: Add ScriptLoadRequest::CacheEntryFound. r=nbp
https://hg.mozilla.org/integration/autoland/rev/087e11d47655
Part 10: Add SharedScriptCache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c67c0db794de
Part 11: Add PContent::ClearScriptCache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/b76b7c999b9d
Part 12: Add SharedScriptCache field to ScriptLoader. r=nbp
https://hg.mozilla.org/integration/autoland/rev/096b5dc2562a
Part 13: Use SharedSubResourceCache in ScriptLoader. r=nbp
https://hg.mozilla.org/integration/autoland/rev/61e179e69463
Part 14: Add ChromeUtils.clearScriptCache* methods. r=nbp
https://hg.mozilla.org/integration/autoland/rev/579d73aad3a4
Part 15: Add nsIDOMWindowUtils.clearSharedScriptCache. r=nbp
https://hg.mozilla.org/integration/autoland/rev/8fed68bb46ba
Part 16: Integrate into nsIClearDataService. r=nbp,extension-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/5b86cade5cdc
Part 17: Add tests. r=nbp

Comment 22

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2c37eaabbc74
https://hg.mozilla.org/mozilla-central/rev/3bdc257459a7
https://hg.mozilla.org/mozilla-central/rev/3de0c9879853
https://hg.mozilla.org/mozilla-central/rev/612ca40ba579
https://hg.mozilla.org/mozilla-central/rev/c0f31a4239be
https://hg.mozilla.org/mozilla-central/rev/6ec335dbf1e6
https://hg.mozilla.org/mozilla-central/rev/30f926126ce2
https://hg.mozilla.org/mozilla-central/rev/674b0b86b1d4
https://hg.mozilla.org/mozilla-central/rev/91e9ae3ba36b
https://hg.mozilla.org/mozilla-central/rev/087e11d47655
https://hg.mozilla.org/mozilla-central/rev/c67c0db794de
https://hg.mozilla.org/mozilla-central/rev/b76b7c999b9d
https://hg.mozilla.org/mozilla-central/rev/096b5dc2562a
https://hg.mozilla.org/mozilla-central/rev/61e179e69463
https://hg.mozilla.org/mozilla-central/rev/579d73aad3a4
https://hg.mozilla.org/mozilla-central/rev/8fed68bb46ba
https://hg.mozilla.org/mozilla-central/rev/5b86cade5cdc