1896845 - Update the replacements for missing functions in bionic to match GeckoView's current minimum Android version

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

The minimum version of Android supported by GeckoView and its derivatives is API 21 (see the wiki page). Because of our use of the Nix crate we had to add some missing functions to the crash reporting code to ensure it would build correctly. Those weren't used, so they would just crash if invoked, but were still needed for linking. In addition to the existing ones we'll soon need the process_vm_readv() and process_vm_writev() for the rust-minidump crate and they'll need to work properly.

To sum it up, based on bionic's list of functions and the Android version in which they were introduced we have to introduce the following changes:

• Remove the mlockall() and munlockall() stubs, those are now available on all the Android architectures we support
• Gate the getgrgid_r() and getgrnam_r() stubs to only be compiled when __ANDROID_API__ < 24
• Add real syscall wrappers for process_vm_readv() and process_vm_writev() and compile them only when __ANDROID_API__ < 23

Checking the [bionic]

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1896845 - Update the replacement functions for the missing ones in bionic r=KrisWright

This also removes some workarounds for prehistoric Android NDKs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e9d02f234c1
Update the replacement functions for the missing ones in bionic r=KrisWright

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2e9d02f234c1