1896892 - Don't double backslashes in URLs when writing links into PDF output

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Jonathan Kew [:jfkthame]]

Spun off from bug 1896076 comment 3. Since updating to cairo-1.18.0, we no longer need to workaround broken backslash handling in the pdf backend, and should remove the code in DrawTargetCairo that is now resulting in duplicated backslashes.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1896892 - Remove the double-escaping of backslashes when writing links to the cairo-pdf backend. r=#gfx-reviewers

This reverts part of bug 1748077, which was working around a quirk of
the cairo pdf backend. The behavior there was fixed upstream in
https://gitlab.freedesktop.org/cairo/cairo/-/issues/526, so since we've
updated to cairo-1.18.0 we no longer need this; it would in fact make
links with backslashes be recorded incorrectly.

Comment 2

[Jonathan Kew [:jfkthame]]

[Tracking Requested - why for this release]:
Regression related to the recent cairo update. This only affects a really obscure edge-case (generating a PDF with a link to a URL with literal backslash in it), but we should avoid shipping the regression to release.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892913

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b526146bf14b
Remove the double-escaping of backslashes when writing links to the cairo-pdf backend. r=gfx-reviewers,jrmuizel

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b526146bf14b

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1896892 - Remove the double-escaping of backslashes when writing links to the cairo-pdf backend.

This reverts part of bug 1748077, which was working around a quirk of
the cairo pdf backend. The behavior there was fixed upstream in
https://gitlab.freedesktop.org/cairo/cairo/-/issues/526, so since we've
updated to cairo-1.18.0 we no longer need this; it would in fact make
links with backslashes be recorded incorrectly.

Original Revision: https://phabricator.services.mozilla.com/D210479

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: link in generated PDF may be incorrect when it includes a literal backslash
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: minimal
• Explanation of risk level: simple removal of a hack we added to workaround a bug in older cairo version
• String changes made/needed: none
• Is Android affected?: yes

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f745652dadd7