Closed Bug 1896920 Opened 6 months ago Closed 5 months ago

Update webidl to match the Lightweight FedCM explainer changes

Categories

(Core :: DOM: Credential Management, enhancement, P1)

Product:
Core
Component:
DOM: Credential Management
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: bvandersloot, Assigned: bvandersloot)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Bug 1896920, part 1 - make expiration time relative - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1896920, part 2 - rename effectivity testing arguments - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1896920, part 3 - Make token usable in lightweight credentials - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review

mt provided some feedback. It's all good, so I'm incorporating it.

Assignee: nobody → bvandersloot
Status: NEW → ASSIGNED
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/153ff0736908 part 1 - make expiration time relative - r=anti-tracking-reviewers,webidl,smaug,pbz https://hg.mozilla.org/integration/autoland/rev/ac92c310e140 part 2 - rename effectivity testing arguments - r=anti-tracking-reviewers,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/ed5199fcf8cb part 3 - Make token usable in lightweight credentials - r=anti-tracking-reviewers,webidl,smaug,pbz
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0843abab6f3b part 1 - make expiration time relative - r=anti-tracking-reviewers,webidl,smaug,pbz https://hg.mozilla.org/integration/autoland/rev/1f466fdca856 part 2 - rename effectivity testing arguments - r=anti-tracking-reviewers,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/737fde266c8d part 3 - Make token usable in lightweight credentials - r=anti-tracking-reviewers,webidl,smaug,pbz

Backed out for causing gv-junit fails related to PromptDelegateTest#fedCMProviderPromptTest

[task 2024-06-04T00:59:25.861Z] 00:59:25     INFO -  TEST-START | org.mozilla.geckoview.test.PromptDelegateTest#fedCMProviderPromptTest
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1142
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | Error in fedCMProviderPromptTest(org.mozilla.geckoview.test.PromptDelegateTest):
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | org.mozilla.geckoview.test.rule.GeckoSessionTestRule$RejectedPromiseException: UnknownError: The operation failed for an unknown transient reason
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForMessage(GeckoSessionTestRule.java:2543)
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.evaluateJS(GeckoSessionTestRule.java:2471)
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForJS(GeckoSessionTestRule.java:2662)
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.waitForJS(BaseSessionTest.kt:250)
[task 2024-06-04T00:59:26.109Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.PromptDelegateTest.fedCMProviderPromptTest(PromptDelegateTest.kt:721)
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test |
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=fedCMProviderPromptTest
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.PromptDelegateTest
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stack=org.mozilla.geckoview.test.rule.GeckoSessionTestRule$RejectedPromiseException: UnknownError: The operation failed for an unknown transient reason
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForMessage(GeckoSessionTestRule.java:2543)
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.evaluateJS(GeckoSessionTestRule.java:2471)
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForJS(GeckoSessionTestRule.java:2662)
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.waitForJS(BaseSessionTest.kt:250)
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.PromptDelegateTest.fedCMProviderPromptTest(PromptDelegateTest.kt:721)
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test |
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=623
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: -2
[task 2024-06-04T00:59:26.110Z] 00:59:26     INFO -  Printing logcat for test:
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.462 E/GeckoSessionTestRule( 3429): test_start 1f0befec-3ff2-40ff-89cf-b127eb38b1ec fedCMProviderPromptTest(org.mozilla.geckoview.test.PromptDelegateTest)
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.462 E/GeckoSessionTestRule( 3429): before prepareStatement fedCMProviderPromptTest(org.mozilla.geckoview.test.PromptDelegateTest)
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.467 E/eglCodecCommon( 7389): glUtilsParamSize: unknow param 0x00008caa
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.518 E/eglCodecCommon( 7389): glUtilsParamSize: unknow param 0x00008caa
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.527 E/eglCodecCommon( 7389): glUtilsParamSize: unknow param 0x00008741
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.535 D/GeckoSession( 3429): handleMessage GeckoView:PageStart uri=about:blank
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.535 E/GeckoSessionTestRule( 3429): method: public abstract void org.mozilla.geckoview.GeckoSession$SelectionActionDelegate.onDismissClipboardPermissionRequest(org.mozilla.geckoview.GeckoSession)
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.535 E/GeckoSessionTestRule( 3429): method: public abstract void org.mozilla.geckoview.GeckoSession$ProgressDelegate.onPageStart(org.mozilla.geckoview.GeckoSession,java.lang.String)
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.536 D/GeckoSession( 3429): handleMessage GeckoView:LocationChange uri=about:blank
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.536 E/GeckoSessionTestRule( 3429): method: public abstract void org.mozilla.geckoview.GeckoSession$NavigationDelegate.onLocationChange(org.mozilla.geckoview.GeckoSession,java.lang.String,java.util.List,java.lang.Boolean)
[task 2024-06-04T00:59:26.563Z] 00:59:26     INFO -  06-04 00:59:25.536 E/GeckoSessionTestRule( 3429): method: public abstract void org.mozilla.geckoview.GeckoSession$NavigationDelegate.onCanGoBack(org.mozilla.geckoview.GeckoSession,boolean)
[task 2024-06-04T00:59:26.564Z] 00:59:26     INFO -  06-04 00:59:25.536 E/GeckoSessionTestRule( 3429): method: public abstract void org.mozilla.geckoview.GeckoSession$NavigationDelegate.onCanGoForward(org.mozilla.geckoview.GeckoSession,boolean)
[task 2024-06-04T00:59:26.564Z] 00:59:26     INFO -  06-04 00:59:25.536 D/GeckoSession( 3429): handleMessage GeckoView:PageStop uri=null
[task 2024-06-04T00:59:26.564Z] 00:59:26     INFO -  06-04 00:59:25.536 E/GeckoSessionTestRule( 3429): method: public abstract void org.mozilla.geckoview.GeckoSession$ProgressDelegate.onPageStop(org.mozilla.geckoview.GeckoSession,boolean)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.536 E/GeckoSessionTestRule( 3429): after prepareStatement
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.540 I/GeckoSession( 3429): zerdatime 573793 - chrome startup finished
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.550 W/GeckoEditableChild( 8338): No editable parent
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.583 D/GeckoSession( 3429): handleMessage GeckoView:ProgressChanged uri=null
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.583 D/GeckoSession( 3429): handleMessage GeckoView:PageStart uri=http://localhost:4245/assets/www/fedcm_rp.html
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.600 W/Web Content( 8338): [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://localhost:4245/assets/www/fedcm_rp.html" line: 0}]
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.610 D/GeckoSession( 3429): handleMessage GeckoView:LocationChange uri=http://localhost:4245/assets/www/fedcm_rp.html
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.611 D/GeckoSession( 3429): handleMessage GeckoView:SecurityChanged uri=null
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.620 D/WebExtension( 3429): handleMessage GeckoView:WebExtension:Connect
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.633 I/Gecko   ( 3429): console.error: "Fail on getting domain pref:" ({})
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.633 E/GeckoConsole( 3429): [JavaScript Error: "Fail on getting domain pref: [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsICookieBannerService.getDomainPref]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/actors/CookieBannerParent.sys.mjs :: receiveMessage :: line 183"  data: no]"]
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.635 D/GeckoSession( 3429): handleMessage GeckoView:ProgressChanged uri=null
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.638 D/GeckoSession( 3429): handleMessage GeckoView:ProgressChanged uri=null
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.645 D/GeckoSession( 3429): handleMessage GeckoView:PageStop uri=null
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): Error
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): org.mozilla.geckoview.test.rule.GeckoSessionTestRule$RejectedPromiseException: UnknownError: The operation failed for an unknown transient reason
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForMessage(GeckoSessionTestRule.java:2543)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.evaluateJS(GeckoSessionTestRule.java:2471)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForJS(GeckoSessionTestRule.java:2662)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.BaseSessionTest.waitForJS(BaseSessionTest.kt:250)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.PromptDelegateTest.fedCMProviderPromptTest(PromptDelegateTest.kt:721)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0(GeckoSessionTestRule.java:1502)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.$r8$lambda$eGWMAiU-In-hdc_ISYHPMUhHPKA(GeckoSessionTestRule.java)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2$$ExternalSyntheticLambda1.run(D8$$SyntheticClass)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1950)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at android.os.Looper.loop(Looper.java:154)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at android.app.ActivityThread.main(ActivityThread.java:6077)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.672 E/GeckoSessionTestRule( 3429): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  06-04 00:59:25.702 E/GeckoSessionTestRule( 3429): test_end c5ee677f-bc83-49bd-9e28-2d35f3d0f059 fedCMProviderPromptTest(org.mozilla.geckoview.test.PromptDelegateTest)
[task 2024-06-04T00:59:26.570Z] 00:59:26  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.PromptDelegateTest#fedCMProviderPromptTest | org.mozilla.geckoview.test.rule.GeckoSessionTestRule$RejectedPromiseException: UnknownError: The operation failed for an unknown transient reason
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  TEST-INFO took 701ms
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1142
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=selectTestSimple
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.PromptDelegateTest
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=624
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: 1
[task 2024-06-04T00:59:26.570Z] 00:59:26     INFO -  TEST-START | org.mozilla.geckoview.test.PromptDelegateTest#selectTestSimple
Flags: needinfo?(bvandersloot)

Backout occurred because some Android junit tests needed the new config. Updating.

Flags: needinfo?(bvandersloot)
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e17b337e290d part 1 - make expiration time relative - r=anti-tracking-reviewers,webidl,smaug,pbz https://hg.mozilla.org/integration/autoland/rev/a7b90461675c part 2 - rename effectivity testing arguments - r=anti-tracking-reviewers,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/64ea6957d0e9 part 3 - Make token usable in lightweight credentials - r=anti-tracking-reviewers,webidl,smaug,pbz

https://hg.mozilla.org/mozilla-central/rev/e17b337e290d
https://hg.mozilla.org/mozilla-central/rev/a7b90461675c
https://hg.mozilla.org/mozilla-central/rev/64ea6957d0e9

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: