Closed Bug 1896932 (disable-hls) Opened 7 months ago Closed 7 months ago

Disable ExoPlayer HLS use (media.hls.enabled pref) in Fenix Nightly to see what breaks

Categories

(GeckoView :: Media, task)

All
Android
task

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: jimm, Assigned: jhlin)

References

(Blocks 1 open bug, Regressed 4 open bugs)

Details

(Whiteboard: [fxdroid])

Attachments

(1 file)

We're going to turn HLS off in Fenix Nightly to see what breaks.

Whiteboard: [fxdroid]

How will we know if something breaks? E.g. will someone be monitoring crashes, user reviews, telemetry..?

  1. I will warn the Android CX team to watch for Nightly user complaints about video playback.
  2. I will monitor Nightly crash reports for new media-related crash reports. 99%+ of websites that had been using Firefox Android's native HLS support (implemented with Exoplayer) will fall back to HLS.js, a JS library that polyfills HLS on top of the MSE API. Perhaps HLS.js will hit some new MSE crashes.
  3. I asked about QA testing HLS websites to make sure websites successfully fall back to the HLS.js library. The Media team already verified that some HLS test websites fell back correctly, but they didn't have a list of real world websites to test.

Risk: Chrome on Android (but not desktop) and Safari (on iOS and macOS) still support HLS natively, so Firefox Android will be the only mobile browser relying on the HLS.js polyfill. Websites will might test HLS.js in Chrome on desktop, but probably not Firefox on Android.

https://github.com/video-dev/hls.js

Summary: Disable ExoPlayer HLS use in Fenix Nightly to see what breaks → Disable ExoPlayer HLS use (media.hls.enabled pref) in Fenix Nightly to see what breaks

Turn off 'native' HLS playback to see if it breaks many contents.
Assuming most websites in production use HLS.js as fallback, the
regression rate should be low.

Tests for HLS playback are disabled temporarily too.

Pushed by jolin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a954ed38114c [expirement] disable HLS in nightly. r=media-playback-reviewers,alwu
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

Latest update from the PlayStore is still at 5-15, so this isn't out yet.

This has rolled out with the 5-17 build and I've confirmed the hls pref is false in it.

See Also: → 1903429
Regressions: 1911081
Depends on: 1912088
Alias: disable-hls
Regressions: 1907832
Regressions: 1913403
Depends on: 1802969
No longer depends on: 1802969
Regressions: 1802969
Regressions: 1913088
See Also: → 1923711
No longer regressions: 1913088
No longer depends on: 1912088
Regressions: 1912088
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: