1896958 - seamonkey 2.53.18.2 fails to build with rust 1.78 due to packed_simd

Status: NEW

(SeaMonkey :: Build Config, defect)

Description

[Landry Breuil (:gaston)]

seems a comeback of bug #1860935, log of the failure:

error[E0557]: feature has been removed   ] 40/48: rust_url_capi, mp4parse_capi, packed_simd                                                                                                                          
   --> /usr/obj/ports/seamonkey-2.53.18.2/seamonkey-2.53.18.2/third_party/rust/packed_simd/src/lib.rs:218:5                                                                                                          
    |                                                                                                                                                                                                                
218 |     platform_intrinsics,                                                                                                                                                                                       
    |     ^^^^^^^^^^^^^^^^^^^ feature has been removed                                                                                                                                                               
    |                                                                                                                                                                                                                
    = note: SIMD intrinsics use the regular intrinsics ABI now   

it builds fine with 1.77.. there's https://github.com/rust-lang/packed_simd/issues/360 upstream

Comment 1

[mac198442]

This looks like the same issue as bug 1882209. I will attempt to backport that but it does not appear that will be a simple task.

Comment 2

[Frank-Rainer Grahl (:frg)]

Well rust is a mess. Such precaion shoukd not happen in minor compiler versions. Any solution must still be comptible with rust 1.73 because we need this compiler version for macOS. If not we can't use it for the official 2.53.x branch, Support for macOS version 10.11 to 10.14 we still support was dropped in 1.74+.

Comment 3

[Jan Alexander Steffens [:heftig]]

Mozilla code is using RUSTC_BOOTSTRAP to access unstable features, so it explicitly opts out of any stability guarantees.

Comment 4

[mac198442]

Working on this, for now the workarounds are either:

1. Build using rust 1.77.2
2. add "ac_add_options --disable-rust-simd" to your mozconfig.

Comment 5

[Landry Breuil (:gaston)]

--disable-rust-simd results in configure failing for me:

KeyError: 'Variable RUST_TEST_FEATURES assigned an empty value.'

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1882209-127a1.zip

You can try this one. We will not putting it in the 2.53 branch because we still support older macOS versions with rust 1.73.

Comment 7

[Landry Breuil (:gaston)]

Comment on attachment 9403797 [details]
1882209-127a1.zip

thanks, after some manual fiddling with the patch (some licences files arent created properly so cargo checksum fails) i've been able to build 2.53.18.2 with rust 1.78 here.

Comment 8

[Frank-Rainer Grahl (:frg)]

Patch was done against 2.53.19b1pre so probably some fallout as stated.