189704 - nsLinebreakConverter.cpp: "Warning (Anachronism): "static" is not allowed and is being ignored"

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect, trivial)

Description

[Roland Mainz]

While compiling 2003-01-15-08-trunk with Sun Workshop 7 I am getting the
following warnings for "nsLinebreakConverter.cpp":
-- snip --
nsLinebreakConverter.cpp
Building deps for
../../../../../../../home/mozilla/src/2003-01-15-08-trunk/mozilla/xpcom/io/nsLinebreakConverter.cpp
/opt/SUNWspro/bin/CC -o nsLinebreakConverter.o -c -DOSTYPE=\"SunOS5\"
-DOSARCH=\"SunOS\" -DOJI -D_IMPL_NS_COM  -I../../dist/include/
string -I../../dist/include/xpcom -I../../dist/include
-I/shared/bigtmp2/mozilla/2003-01-15-08-trunk/objdir_ws7_gtk/dist/include/nsp
r      -I/usr/openwin/include   -KPIC  -I/usr/openwin/include -xbuiltin=%all
-mt  -DDEBUG -D_DEBUG -DDEBUG_mozilla -DTRACING -g -g  
-I/usr/openwin/include -DSOLARIS=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1
-DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGIN
FO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1
-DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_WCRTOMB=1 -DHAVE_MB
RTOWC=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1
-DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_SYS_STATVFS_H=1 -D
HAVE_SYS_STATFS_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DNEW_H=\<new\>
-DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DHAVE_LIBSOCKET=1 -DFUNCPR
OTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1
-DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_STATV
FS=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_NL_LANGINFO=1 -DHAVE_FLOCKFILE=1
-DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_ICONV=1 -D
HAVE_ICONV_WITH_CONST_INPUT=1 -DHAVE_IOS_BINARY=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX=1 -DHAVE_CPP_PA
RTIAL_SPECIALIZATION=1 -DHAVE_CPP_ACCESS_CHANGING_USING=1
-DHAVE_CPP_AMBIGUITY_RESOLVING_USING=1 -DHAVE_CPP_NAMESPACE_STD=1 -DHAVE_C
PP_UNAMBIGUOUS_STD_NOTEQUAL=1 -DHAVE_CPP_NEW_CASTS=1
-DHAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR=1 -DNEED_CPP_UNUSED_IMPLEMENTATIONS=1 -DHAV
E_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DMOZ_WIDGET_GTK=1
-DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_ENABLE_COREXFONTS=1 -
DIBMBIDI=1 -DACCESSIBILITY=1 -DMOZ_MATHML=1 -DMOZ_SVG=1 -DMOZ_LOGGING=1
-DDETECT_WEBSHELL_LEAKS=1 -DMOZ_USER_DIR=\".mozilla\" -DCPP_
THROW_NEW=throw\(\) -DMOZ_XUL=1 -DINCLUDE_XUL=1 -DNS_MT_SUPPORTED=1 -DSUNCTL=1
-DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS
=1 -DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZ_REFLOW_PERF=1
-DMOZ_REFLOW_PERF_DSP=1  -DMOZILLA_CLIENT ../../../../
../../../home/mozilla/src/2003-01-15-08-trunk/mozilla/xpcom/io/nsLinebreakConverter.cpp
"../../../../../../../home/mozilla/src/2003-01-15-08-trunk/mozilla/xpcom/io/nsLinebreakConverter.cpp",
line 126: Warning (Anachronis
m): "static" is not allowed and is being ignored.
"../../../../../../../home/mozilla/src/2003-01-15-08-trunk/mozilla/xpcom/io/nsLinebreakConverter.cpp",
line 220: Warning (Anachronis
m): "static" is not allowed and is being ignored.
"../../../../../../../home/mozilla/src/2003-01-15-08-trunk/mozilla/xpcom/io/nsLinebreakConverter.cpp",
line 243: Warning (Anachronism): "static" is not allowed and is being ignored.
3 Warning(s) detected.
-- snip --

Comment 1

[Doug Turner (:dougt)]

over to simon - his file.

Comment 2

[Serge Gautherie (:sgautherie)]

MXR: nsLinebreakConverter.cpp | 1.13 |
{
125 template<class T>
126 static T* ConvertBreaks(const T* inSrc, PRInt32& ioLen, const char*
srcBreak, const char* destBreak)

219 template<class T>
220 static void ConvertBreaksInSitu(T* inSrc, PRInt32 inLen, char srcBreak, char
destBreak)

242 template<class T>
243 static T* ConvertUnknownBreaks(const T* inSrc, PRInt32& ioLen, const char*
destBreak)
}

Is the correct fix to remove the |static| ??

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

hmm... why is static not allowed there?