1897278 - Add a method to BackupService to enable encryption and persist the state to disk, and to disable

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

This is based on the work in bug 1896715. In this bug, we will:

1. Add an ArchiveEncryptionState instance member to BackupService. Have this be a lazy member that will attempt to read a pre-existing ArchiveEncryptionState off of disk after instantiation if one exists.
2. Add a method to BackupService to enable encryption using some password ("recovery code") which calls enable on the ArchiveEncryptionState, and then persists the state to disk. This method should throw if encryption is already enabled.
3. Allow for disabling encryption as well.
4. Only allow BackupResource's with requiresEncryption to have backup run if encryption is enabled
5. Add UI to the debug tool to enable / disable encryption.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1897278 - Make the backups profile folder a constant accessible off of the BackupService class. r?#backup-reviewers!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1897278 - Add methods to BackupService to enable / disable encryption. r?#backup-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5e43f371c09
Make the backups profile folder a constant accessible off of the BackupService class. r=backup-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/b24523dedba4
Add methods to BackupService to enable / disable encryption. r=backup-reviewers,kpatenio

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell failures in test_BackupService_enable_disable_encryption.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/backup/tests/xpcshell/test_BackupService_enable_disable_encryption.js | xpcshell return code: -11

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27580a94c5ee
Make the backups profile folder a constant accessible off of the BackupService class. r=backup-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/c66527750231
Add methods to BackupService to enable / disable encryption. r=backup-reviewers,kpatenio

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/27580a94c5ee
https://hg.mozilla.org/mozilla-central/rev/c66527750231