1897279 - New wpt failures in /css/css-anchor-position/last-successful-intermediate-ignored.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 46298 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-anchor-position/last-successful-basic.html [wpt.fyi]
  • Starts rendering with flip-block: FAIL (Chrome: PASS, Safari: FAIL)
  • Base position without option now successful: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-anchor-position/last-successful-change-options.html [wpt.fyi]
  • Starts rendering with flip-block: FAIL (Chrome: PASS, Safari: FAIL)
  • No successful position, last successful invalidated by position-try-options change: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-anchor-position/last-successful-change-try-rule.html [wpt.fyi]
  • Starts rendering with --try: FAIL (Chrome: PASS, Safari: FAIL)
  • No successful position, last successful invalidated by @position-try change: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-anchor-position/last-successful-intermediate-ignored.html [wpt.fyi]
  • Starts rendering with flip-block: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1897023 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Jonathan Watt [:jwatt]]

This can also cover:

/css/css-anchor-position/last-successful-change-fallbacks.html [wpt.fyi]

Comment 2

[Daniel Holbert [:dholbert]]

Probably also makes sense for this to cover the one failure shown on wpt.fyi here:
/css/css-anchor-position/last-successful-iframe.html [wpt.fyi]

(Also, Bug 1983943 comment 1 has some similar test failures to the ones here, though in tests that aren't included in interop-2025. --> Adding see-also)

Comment 3

[Jonathan Kew [:jfkthame]]

I believe the failures here are caused by bug 1924792 (i.e. we're handling the last-successful-position aspect correctly, but failing to shift the anchored element to stay within its original containing block).

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org) from comment #0)

• /css/css-anchor-position/last-successful-change-options.html [wpt.fyi]
  • Starts rendering with flip-block: FAIL (Chrome: PASS, Safari: FAIL)
  • No successful position, last successful invalidated by position-try-options change: FAIL (Chrome: PASS, Safari: FAIL)

This test was renamed to "last-successful-change-fallbacks.html" (wpt.fyi), in bug 1906305's merge from upstream. (EDIT: ah, turns out that new name is the test mentioned in comment 1.)

We still fail some subtests in it.

Comment 5

[Daniel Holbert [:dholbert]]

Looks like bug 1924792 entirely fixed (removed the .ini file for) these tests:
https://wpt.fyi/results/css/css-anchor-position/last-successful-change-fallbacks.html
https://wpt.fyi/results/css/css-anchor-position/last-successful-iframe.html

\o/

But, we still fail one subtest in these tests from comment 0:

• https://wpt.fyi/results/css/css-anchor-position/last-successful-change-try-rule.html
  (subtest "No successful position, last successful invalidated by @position-try change")
  (though bug 1924792 fixed another subtest in that this one, hooray!)

• https://wpt.fyi/results/css/css-anchor-position/last-successful-intermediate-ignored.html
  (subtest "No successful position (with intermediate successful), keep flip-block")

--> Reducing bug summary's scope to cover those those still-failing tests.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

last-successful-intermediate-ignored.html is the only remaining failure now.

Comment 7

[Jonathan Watt [:jwatt]]

Not actively working on the anchor-pos project ATM.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

It seems we need to track the last successful fallback but also the last committed last successful fallback. Should be relatively straight-forward (famous last words).

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1897279 - Record last successful fallback at ResizeObserver time. r=dshin,#anchor-positioning-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c549b667cd04
https://hg.mozilla.org/integration/autoland/rev/d3f9ae3d66a9
Record last successful fallback at ResizeObserver time. r=dshin,layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d3f9ae3d66a9