1897343 - [rustc 1.79] error: field `verbose` is never read

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-05-17T01:25:42.378Z] error: field `verbose` is never read
[task 2024-05-17T01:25:42.378Z]    --> wrench/src/wrench.rs:209:9
[task 2024-05-17T01:25:42.378Z]     |
[task 2024-05-17T01:25:42.378Z] 196 | pub struct Wrench {
[task 2024-05-17T01:25:42.378Z]     |            ------ field in this struct
[task 2024-05-17T01:25:42.378Z] ...
[task 2024-05-17T01:25:42.378Z] 209 |     pub verbose: bool,
[task 2024-05-17T01:25:42.378Z]     |         ^^^^^^^
[task 2024-05-17T01:25:42.378Z]     |
[task 2024-05-17T01:25:42.378Z]     = note: `-D dead-code` implied by `-D warnings`
[task 2024-05-17T01:25:42.378Z]     = help: to override `-D warnings` add `#[allow(dead_code)]`
[task 2024-05-17T01:25:42.378Z] 
[task 2024-05-17T01:25:42.415Z] error: could not compile `wrench` (lib) due to 1 previous error

Also:

[task 2024-05-17T01:24:05.220Z] error: fields `z_id` and `transform_id` are never read
[task 2024-05-17T01:24:05.220Z]    --> webrender/src/gpu_types.rs:546:9
[task 2024-05-17T01:24:05.220Z]     |
[task 2024-05-17T01:24:05.220Z] 542 | pub struct QuadInstance {
[task 2024-05-17T01:24:05.220Z]     |            ------------ fields in this struct
[task 2024-05-17T01:24:05.220Z] ...
[task 2024-05-17T01:24:05.220Z] 546 |     pub z_id: ZBufferId,
[task 2024-05-17T01:24:05.220Z]     |         ^^^^
[task 2024-05-17T01:24:05.220Z] 547 |     pub transform_id: TransformPaletteId,
[task 2024-05-17T01:24:05.220Z]     |         ^^^^^^^^^^^^
[task 2024-05-17T01:24:05.220Z]     |
[task 2024-05-17T01:24:05.220Z]     = note: `QuadInstance` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[task 2024-05-17T01:24:05.220Z]     = note: `-D dead-code` implied by `-D warnings`
[task 2024-05-17T01:24:05.220Z]     = help: to override `-D warnings` add `#[allow(dead_code)]`
[task 2024-05-17T01:24:05.220Z] 
[task 2024-05-17T01:24:05.220Z] error: field `format` is never read
[task 2024-05-17T01:24:05.220Z]    --> webrender/src/render_target.rs:160:9
[task 2024-05-17T01:24:05.220Z]     |
[task 2024-05-17T01:24:05.220Z] 159 | pub struct RenderTargetList<T> {
[task 2024-05-17T01:24:05.220Z]     |            ---------------- field in this struct
[task 2024-05-17T01:24:05.220Z] 160 |     pub format: ImageFormat,
[task 2024-05-17T01:24:05.220Z]     |         ^^^^^^
[task 2024-05-17T01:24:05.220Z] 
[task 2024-05-17T01:24:05.221Z] error: field `filter` is never read
[task 2024-05-17T01:24:05.221Z]   --> webrender/src/picture_textures.rs:48:9
[task 2024-05-17T01:24:05.221Z]    |
[task 2024-05-17T01:24:05.221Z] 37 | pub struct PictureCacheEntry {
[task 2024-05-17T01:24:05.221Z]    |            ----------------- field in this struct
[task 2024-05-17T01:24:05.221Z] ...
[task 2024-05-17T01:24:05.221Z] 48 |     pub filter: TextureFilter,
[task 2024-05-17T01:24:05.221Z]    |         ^^^^^^
[task 2024-05-17T01:24:05.221Z]    |
[task 2024-05-17T01:24:05.221Z]    = note: `PictureCacheEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[task 2024-05-17T01:24:05.221Z] 
[task 2024-05-17T01:24:05.461Z] error: could not compile `webrender` (lib) due to 3 previous errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1897343 - Remove some dead code detected by rustc 1.79.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89a79daf9086
Remove some dead code detected by rustc 1.79. r=gfx-reviewers,nical

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/89a79daf9086

Comment 4

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/88d3f3e60c34

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cec52a8d9c97
Remove some dead code detected by rustc 1.79. r=gfx-reviewers,nical

Comment 6

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/cec52a8d9c97