1897349 - Perma OS X opt + shippable accessible/tests/browser/tree/browser_css_alt.js | Wrong value of property 'name' for [role: statictext, name: 'before', address: [xpconnect wrapped nsIAccessible]]. - Got "before", expected "alt"

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Treeherder Bug Filer]

Filed by: tszentpeteri [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=458543265&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QindZIHfThKYrg6jvoq_Jg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QindZIHfThKYrg6jvoq_Jg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2024-05-17T01:18:27.158Z] 01:18:27     INFO - TEST-PASS | accessible/tests/browser/tree/browser_css_alt.js | Wrong value of property 'role' for [role: statictext, name: 'before', address: [xpconnect wrapped nsIAccessible]]. - 
[task 2024-05-17T01:18:27.158Z] 01:18:27     INFO - Buffered messages finished
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/tree/browser_css_alt.js | Wrong value of property 'name' for [role: statictext, name: 'before', address: [xpconnect wrapped nsIAccessible]]. - Got "before", expected "alt"
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - Stack trace:
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - chrome://mochikit/content/browser-test.js:test_is:1620
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:testAccessibleTree:547
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:testAccessibleTree:700
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - chrome://mochitests/content/browser/accessible/tests/browser/tree/browser_css_alt.js:testTextPseudo:230
[task 2024-05-17T01:18:27.161Z] 01:18:27     INFO - chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:accessibleTask/</<:554
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:accessibleTask/<:473
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1122
[task 2024-05-17T01:18:27.162Z] 01:18:27     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-05-17T01:18:27.163Z] 01:18:27     INFO - TEST-PASS | accessible/tests/browser/tree/browser_css_alt.js | Wrong parent of [role: text leaf, name: 'inside', address: [xpconnect wrapped nsIAccessible]] - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Jamie, since you are the author of the regressor, bug 1896047, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1896047

Comment 3

[Serban Stanca [:SerbanS]]

This is permafailing on OS X 11 WebRender Shippable as it can be seen here.

Jamie, could you please take a look at this?

Thank you!

Comment 4

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Setting the severity as S3, in case it’s also related to the pref differences.

Comment 5

[Intermittent Failures Robot]

19 failures in 4547 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 14
• try: 2

Platform and build breakdown:

• macosx1015-64-qr: 3
  • debug: 1
  • opt: 2
• macosx1100-64-shippable-qr: 14
  • opt: 14
• macosx1015-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1897349&startday=2024-05-13&endday=2024-05-19&tree=all

Comment 6

[Cosmin Sabou [:CosminS]]

This is permafailing on tier 1 jobs so a fix here soon would be appreciated to avoid backing out the regressor.

Comment 7

[James Teh [:Jamie]]

I was waiting for bug 1897430 to land to see if it fixed this. I'll push a try build shortly to check. I don't really understand why this would be failing; I don't know the difference between "shippable" builds vs normal Mac builds or why it would impact this, so that will need investigation.

Comment 8

[James Teh [:Jamie]]

I'm looking into this. This doesn't seem to be related to the pref, since earlier tests in this file are passing that I would otherwise expect to fail. I don't quite know what the fix is yet, but I have some early thoughts.

Note to self: What happens if layout updates the text in the pseudo-element for some reason after a11y has already created an Accessible for it? Do we need code in WillRefresh to skip TextUpdater where CSS alt text is present?

Comment 9

[James Teh [:Jamie]]

Try before the fix
Try with speculative fix

Comment 10

[James Teh [:Jamie]]

Attachment: Bug 1897349: Don't update CSS pseudo-element TextLeafAccessibles if there is CSS content alt text.

When we create a TextLeafAccessible for a CSS pseudo-element, we already use the alt text if present.
However, it seems layout sometimes re-renders the text of pseudo-elements.
Previously, a11y would update the text in this case like it would for any other TextLeafAccessible, thus overwriting the alt text with the text rendered by layout.
To fix this, we now skip updating text if CSS alt text is present.

Comment 11

[James Teh [:Jamie]]

Patch seems to fix this.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eab0cf09064
Don't update CSS pseudo-element TextLeafAccessibles if there is CSS content alt text. r=eeejay

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8eab0cf09064

Comment 14

[Intermittent Failures Robot]

28 failures in 3995 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 12
• try: 11

Platform and build breakdown:

• macosx1015-64-qr: 4
  • opt: 4
• macosx1100-64-shippable-qr: 13
  • opt: 13
• macosx1015-64-shippable-qr: 6
  • opt: 6
• macosx1015-64-devedition-qr: 2
  • opt: 2
• linux1804-64-qr: 1
  • opt: 1
• linux1804-64-devedition-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1897349&startday=2024-05-20&endday=2024-05-26&tree=all