1897371 - [Windows] Text selection cleared when screenshot is taken

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Notes

• This is a follow-up from bug 1887093.

Found in

• Firefox Nightly 128.0a1;

Affected versions

• Firefox Nightly 128.0a1;

Tested platforms

• macOS 12;
• Windows 10;
• Ubuntu 22;

Affected platforms

• Windows 10;

Unaffected platforms

• macOS 12;
• Ubuntu 22;

Steps to reproduce

1. Launch Firefox.
2. Go to Hamburger Menu -> More Tools -> Customize toolbar.. and add the Screenshot button in the toolbar.
3. Go to any random website, eg. www.wikipedia.com
4. Select some text from the page.
5. Take a screenshot of the highlighted section.

Expected result

• Text selection remains highlighted.

Actual result

• Text selection loses highlight.

Regression range

• last good: 2024-03-04
• first bad: 2024-03-05
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2aa589c9e655b54dc77209268450e5e4d16a9fc9&tochange=5b706eb2187070200b3eecb6d99a95e750c3266e
• potentially regressed by: bug 1789727

Comment 1

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Mozregression results:

• last good: 2024-03-04
• first bad: 2024-03-05
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2aa589c9e655b54dc77209268450e5e4d16a9fc9&tochange=5b706eb2187070200b3eecb6d99a95e750c3266e
• potentially regressed by: bug 1789727

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789727

:niklas, since you are the author of the regressor, bug 1789727, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Niklas Baumgardner [:niklas]]

Are you able to reproduce this on Windows 11?
I'm using Windows 11 and I'm not able to reproduce.

Could you share a video of the STR?

Comment 4

[Alice0775 White]

I can reproduce the issue on Nightly128.0a1 Windows11.

Steps to reproduce:

1. Open web page e.g. https://en.wikipedia.org/wiki/Main_Page
2. Select some text
3. Right click on content area and choose Take Screenshot
4. Try to select region to take screenshot by mouse dragging
   ---- Text selection is corrupted at the dragend. Bug!

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: selection bug.gif

STR used:

1. Launch Firefox.
2. Go to any random website, eg. www.wikipedia.com
3. Select some text from the page.
4. Right-click on the page to open context menu and choose 'Take Screenshot' option.
5. Try to take a screenshot of the highlighted section.

Issue is also reproducible if using the Screenshot tool.
Windows 11, Version 23H2(OS build 22631.3447).
Please note that this issue is reproducible only on Firefox Nightly 128.0a1.

Comment 6

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1897371 - Handle selectionchange events in screenshots overlay.r=sfoster,kcochrane

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c9ff83d58cc
Handle selectionchange events in screenshots overlay.r=kcochrane

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9c9ff83d58cc

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Niklas Baumgardner [:niklas]]

Comment on attachment 9402486 [details]
Bug 1897371 - Handle selectionchange events in screenshots overlay.r=sfoster,kcochrane

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to screenshot a selected text region in screenshots component release
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR:

1. Go to any page with text https://en.wikipedia.org/wiki/Firefox
2. select some text on the page
3. open screenshots
4. select a region on the page that includes the selected text
5. copy or download the screenshot

ER:
the image should have selected text

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This was already in 127 but was accidentally regressed in bug 1890721
• String changes made/needed: No
• Is Android affected?: No

Comment 11

[Pascal Chevrel:pascalc]

Niklas, if this was regressed in bug 1890721 (v128), then the regression can't be on the beta branch (v127). Are you sure we have the bug in beta? I tried to reproduce it but it works for me on beta 7.

Comment 12

[Peter Magyari (Desktop QA)]

I have reproduced the issue using Nightly 128.0a1 (20240527092611) and verified the fix using Nightly 128.0a1 (20240529013712) on Windows 10,
MacOS 14.04 and Ubuntu 24.04.

Also, as Pascal mentioned in Comment 11, I cannot reproduce the issue on Beta 127.0b7 either.

Comment 13

[Niklas Baumgardner [:niklas]]

(In reply to Pascal Chevrel:pascalc from comment #11)

Niklas, if this was regressed in bug 1890721 (v128), then the regression can't be on the beta branch (v127). Are you sure we have the bug in beta? I tried to reproduce it but it works for me on beta 7.

My apologies. I thought I had uplifted bug 1890721 but I must've been looking at the wrong bug.

Thanks for catching my mistake! Sorry about the confusion.