189740 - [ps] Adding CID support Check Code to postscript should be closed when TrueType printing is disabled

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Louie Zhao]

Now the "CID support Check Code" will be added to postscript if freetype is
enabled. The most Linux users (their systems have freetype) who don't enable
TrueType printing will still have these checking code in postscript when printing.

bstell: will the CID checking code stop the printing process if the printer
doesn't support CID? If answer is yes, I think the patch should be applied; if
answer is no, the current code is ok.

Comment 1

[Louie Zhao]

Attachment: working patch

Stop outputing CID check code to postscript when TrueType printing is disabled.

Comment 2

[Pete Zha]

Comment on attachment 112019 [details] [diff] [review]
working patch

Louie, we should also determine whether we have embedded the CID fonts

Comment 3

[Louie Zhao]

Attachment: patch following pete's suggestion

updated patch

Comment 4

[kill this account]

Looks great!

Minor nit: could we change mTTPEnable to mFTPEnable?

+    if (mTTPEnable) {
+      rv = pref->GetBoolPref("font.FreeType2.printing", &mTTPEnable);

I had noticed it embedded fonts even if they were not used so I was happy to see
this:

-  FT2SubsetToType8(face, mSubset.get(), mSubset.Length(), wmode, aFile);
+  if (mSubset.Length() > 0)
+    FT2SubsetToType8(face, mSubset.get(), mSubset.Length(), wmode, aFile);

Comment 5

[Louie Zhao]

Attachment: patch following bstell's comments

Comment 6

[Louie Zhao]

Comment on attachment 112120 [details] [diff] [review]
patch following bstell's comments

bring bstell's "r" here

Comment 7

[Christopher Blizzard (:blizzard)]

Comment on attachment 112120 [details] [diff] [review]
patch following bstell's comments

sr=blizzard

Comment 8

[Pete Zha]

checked in by [e-mail] on 01/21/2003