Closed Bug 1897403 Opened 9 months ago Closed 9 months ago

moztest.resolve doesn't handle wpt tests with a query string containign a `/`

Categories

(Testing :: web-platform-tests, defect, P1)

defect

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

References

Details

Attachments

(1 file)

If you have a test with an id like /foo/bar/baz?foobar=sp/am" thenmoztestis putting that in a group likefoo/bar/baz?foobar=sprather thanfoo/bar/bazbecause we're trying to parse test ids as os pathnames rather than URLs. This later breaks the metadata update which is trying to convert the group name into a filesystem path for thedir.ini` file.

wpt test ids are URLs, and can have query components. This means that
using os.path.dirname isn't a correct way to extract different parts
of the URL

In particular a test id like /foo/bar/baz?foobar=sp/am can lead to an
invalid group name like foo/bar/baz?foobar=sp, which breaks the
invariant that we can turn the group name into a filesystem path that
may contain a dir.ini file with metadata for that group.

The fix here is to correctly treat the test id as a URL using the same
logic as in wptrunner.

Assignee: nobody → james
Status: NEW → ASSIGNED
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/778b00802571 Handle wpt test id as a URL when computing group name, r=Sasha
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: