1897477 - Remove inline event handlers from <command>

Status: RESOLVED FIXED

(Firefox :: General, task)

Comment 1

[Tom Schuster (MoCo)]

Attachment: Bug 1897477 - Remove inline event handlers from <command> in mainCommandSet. r?gijs

Comment 2

[Tom Schuster (MoCo)]

Attachment: Bug 1897477 - Remove inline event handlers from <command> for downloads. r?gijs

Depends on D210815

Comment 3

[Tom Schuster (MoCo)]

Attachment: Bug 1897477 - Update test that uses oncommand for eval. r?Gijs

Depends on D211191

Comment 4

[Tom Schuster (MoCo)]

Attachment: Bug 1897477 - Update XUL elements that rely on `observes` copying the `oncommand` attribute. r?Gijs

Some uses of observes especially observes="*" or attribute="oncommand"
were relying on XULBroadcastManager::SynchronizeBroadcastListener
actually copying the inline event handler oncommand from their
corresponding command element.

I manually search for this using:
https://searchfox.org/mozilla-central/search?q=observes%5Cs*%3D%5Cs*%22&path=&case=false&regexp=true
and
https://searchfox.org/mozilla-central/search?q=%3C%5Cs*observes&path=&case=false&regexp=true

Depends on D211721

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20ef2c07be32
Remove inline event handlers from <command> in mainCommandSet. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a63e0d13ee34
Remove inline event handlers from <command> for downloads. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/ab21bb3052dd
Update test that uses oncommand for eval. r=Gijs

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/20ef2c07be32
https://hg.mozilla.org/mozilla-central/rev/a63e0d13ee34
https://hg.mozilla.org/mozilla-central/rev/ab21bb3052dd