Closed Bug 1897706 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 46369 - Prerender: Remove unnecessary params on speculation rules WPT

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox128 fixed)

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46369 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46369
Details from upstream follow.

Hiroki Nakagawa <nhiroki@chromium.org> wrote:

Prerender: Remove unnecessary params on speculation rules WPT

This is a cleanup CL that doesn't change functional behavior.

Before this CL, create_prerendered_page() created URLSearchParams() with
baseUrl.search. However, baseUrl is a string representation of URL
path that doesn't have the search field. This should be no-op.

This CL stops passing baseUrl.search to URLSearchParams().

Bug: 340928303
Change-Id: I82d0ee072ef609e61656b9cdc198738c71a168ba

Reviewed-on: https://chromium-review.googlesource.com/5547290
WPT-Export-Revision: 3b7670f62d0cdd55a84658538ea27e47e8bd4b4c

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 3 subtests

Status Summary

Firefox

FAIL : 2
ERROR : 142

Chrome

OK : 106
PASS : 119
FAIL : 10
TIMEOUT: 74
NOTRUN : 5

Safari

FAIL : 2
ERROR : 142

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51fb6106e982 [wpt PR 46369] - Prerender: Remove unnecessary params on speculation rules WPT, a=testonly

https://hg.mozilla.org/mozilla-central/rev/51fb6106e982

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.