1897708 - [MX] [elpalaciodelhierrro.com] Autofiil doesn't work on Last Name field in payment form

Status: ASSIGNED

(Toolkit :: Form Autofill, task, P3)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue - elpalaciodehierro.gif

Found in

• 128.0a1

Affected versions

• N/A

Tested platforms

• Affected platforms: Windows 10

Preconditions

• browser.search.region US
• Have at least one CC already saved

Steps to reproduce

1. Reach the payment form on https://www.elpalaciodehierro.com/
2. Click inside "Apellidos" field.

Expected result

• The preview/ autofill/clear should word for all fields.

Actual result

• The preview/ autofill /clear is not working for "Apellidos" field.

Regression range

• N/A

Additional notes

• Not reproducible on Chrome, First name and Last name are autofilled independently, though the corresponding field.
• • Fathom Fox Sample
• In Firefox Nombre(s) filed handles both First Name and Last Name (see screecast)

Comment 1

[Johannes]

• no iframes involved
• 4 sections: [{"type":"creditCard"},{"type":"creditCard"},{"type":"creditCard"},{"type":"address"}]
• field infos:

[{"elementWeakRef":{},"identifier":"dwfrm_billing_palacioCardFields_cardNumber/dwfrm_billing_palacioCardFields_cardNumber","fieldName":"cc-number","reason":"autocomplete","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":null}]

[{"elementWeakRef":{},"identifier":"dwfrm_billing_palacioCardFields_expirationDate/dwfrm_billing_palacioCardFields_expirationDate","fieldName":"cc-number","reason":"regex-heuristic","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_palacioCardFields_cardOwner/dwfrm_billing_palacioCardFields_cardOwner","fieldName":"cc-name","reason":"fathom","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":0.8945802719073781}]

[{"elementWeakRef":{},"identifier":"dwfrm_billing_palacioCardFields_cardOwner2/dwfrm_billing_palacioCardFields_cardOwner2","fieldName":"cc-name","reason":"fathom","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":0.8945802719073781},{"elementWeakRef":{},"identifier":"dwfrm_billing_creditCardFields_cardNumber/dwfrm_billing_creditCardFields_cardNumber","fieldName":"cc-number","reason":"autocomplete","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_creditCardFields_expirationDate/dwfrm_billing_creditCardFields_expirationDate","fieldName":"cc-number","reason":"regex-heuristic","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_creditCardFields_cardOwner/dwfrm_billing_creditCardFields_cardOwner","fieldName":"cc-name","reason":"fathom","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":0.8945802719073781},{"elementWeakRef":{},"identifier":"dwfrm_billing_creditCardFields_cardOwner2/dwfrm_billing_creditCardFields_cardOwner2","fieldName":"cc-name","reason":"fathom","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":0.8945802719073781}]

[{"elementWeakRef":{},"identifier":"dwfrm_billing_addressFields_countries_countryCode/dwfrm_billing_addressFields_countries_countryCode","fieldName":"country","reason":"regex-heuristic","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_addressFields_postalCode/dwfrm_billing_addressFields_postalCode","fieldName":"postal-code","reason":"autocomplete","section":"","addressType":"billing","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_addressFields_states_stateCode/dwfrm_billing_addressFields_states_stateCode","fieldName":"address-level1","reason":"autocomplete","section":"","addressType":"billing","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_addressFields_city/dwfrm_billing_addressFields_city","fieldName":"address-level2","reason":"autocomplete","section":"","addressType":"billing","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_addressFields_address1/dwfrm_billing_addressFields_address1","fieldName":"address-line1","reason":"autocomplete","section":"","addressType":"billing","contactType":"","credentialType":"","part":null,"confidence":null},{"elementWeakRef":{},"identifier":"dwfrm_billing_contactInfoFields_phone/dwfrm_billing_contactInfoFields_phone","fieldName":"tel","reason":"regex-heuristic","section":"","addressType":"","contactType":"","credentialType":"","part":null,"confidence":null}]

Comment 2

[Tessa Heidkamp]

Attachment: Bug 1897708 Fixing mismatched autofill for expiry date field in payment form

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d527094ec903
Fixing mismatched autofill for expiry date field in payment form r=dimi,credential-management-reviewers

Comment 4

[Dimi Lee [:dimi]]

leave the bug open since tessa's patch only fixes part of the issue.

Comment 5

[Cristian Tuns]

Backed out for causing bc failures in browser_Euronics.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/heuristics/third_party/browser_Euronics.js | Uncaught exception in test bound - Expected section count. - timed out after 50 tries.

Comment 6

[Dimi Lee [:dimi]]

hi tessa, could you help take a look at the test failure? thank you!

Comment 7

[Tessa Heidkamp]

Attachment: Bug 1897708 - Fixing mismatched autofill for expiry date field in payment form. r=dimi

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f52eae0ac827
Fixing mismatched autofill for expiry date field in payment form. r=dimi

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f52eae0ac827

Comment 10

[Tessa Heidkamp]

The credit card form fields for given name and family name both get classified as cc-name field by Fathom. This results in only one field being filled with the full name, the other remains empty. The fields should be reclassified as given-name and family-name. But reclassification for adjacent name fields in the credit card field context is only implemented for fields that are identified using the regex-based heuristics. (in _parseCreditCardNameFields)