Closed
Bug 1897785
Opened 14 days ago
Closed 3 days ago
Update API on `TranslationsAction.OperationRequestedAction` To Accept an Optional TabID
Categories
(Fenix :: Translations, task, P2)
Tracking
(firefox128 fixed)
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: olivia, Assigned: olivia)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][foundation][translations:128])
Attachments
(1 file)
For the series TranslationsAction.OperationRequestedAction, requires a tab ID. This is only a requirement for the page settings API. This change is to make tabId fully optional and for page settings, as a sensible default, to use the current tab and issue a warning.
|
Assignee | |
Updated•14 days ago
|
Severity: -- → N/A
Type: defect → task
Component: Accounts and Sync → Translations
Priority: -- → P2
|
||
Updated•14 days ago
|
|
|
Assignee | |
Comment 1•14 days ago
|
||
Most calls under OperationRequestedAction do not require a tabId because they change
information on the global store and not the session store.
- This patch makes
tabIdan optional forOperationRequestedAction - For the one call,
FETCH_PAGE_LANGUAGES, that does require a tabId a
sensible default of the current tab will be used and a warning will be logged.
Depends on D210562
|
||
Updated•14 days ago
|
Assignee: nobody → ohall
Status: NEW → ASSIGNED
Pushed by ohall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c561b26d0e8 Update Translations `OperationRequestedAction` to Not Require a Tab ID r=android-reviewers,giorga
|
||
Comment 3•3 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•