1897837 - New wpt failures in /css/css-color/parsing/color-valid-relative-color.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 46377 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-color/parsing/color-valid-relative-color.html [wpt.fyi]
  • e.style['color'] = "hsl(from rebeccapurple none none none / none)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
  • e.style['color'] = "hsla(from rebeccapurple none none none / none)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1897817 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org) from comment #0)

Syncing wpt PR 46377 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-color/parsing/color-valid-relative-color.html [wpt.fyi]
  • e.style['color'] = "hsl(from rebeccapurple none none none / none)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
  • e.style['color'] = "hsla(from rebeccapurple none none none / none)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)

We pass these subtests now, FWIW. We do have some other failures in this test but at first glance they look like they're cases where we're unwrapping calc() expressions when the test expects us not to.

Comment 3

[Mathew Hodson]

Most of the tests were fixed in bug 1893966

Comment 4

[Tiaan Louw [:tlouw]]

Attachment: Bug 1897837 - Track and serialize calc(..) nodes in relative colors correctly. r=#layout

• Serialize color components with calc(..) when specified in a calc node.
• Channel keywords outside calc(..) are serialized without calc(..).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c90312a306a3
Track and serialize calc(..) nodes in relative colors correctly. r=layout-reviewers,emilio

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c90312a306a3

Comment 7

[Tiaan Louw [:tlouw]]

Attachment: Bug 1897837 - Track and serialize calc(..) nodes in relative colors correctly. r=#layout

• Serialize color components with calc(..) when specified in a calc node.
• Channel keywords outside calc(..) are serialized without calc(..).

Original Revision: https://phabricator.services.mozilla.com/D233234

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No impact on users
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: None
• Explanation of risk level: Fixes edge case serialization for relative colors which is a very new feature
• String changes made/needed: n/a
• Is Android affected?: yes

Comment 9

[Tiaan Louw [:tlouw]]

This uplift will increase our interop 2024 score for relative color syntax and would be great to include in 135.

Comment 10

[Tiaan Louw [:tlouw]]

Attachment: Bug 1897837 - Track and serialize calc(..) nodes in relative colors correctly. r=#layout

• Serialize color components with calc(..) when specified in a calc node.
• Channel keywords outside calc(..) are serialized without calc(..).

Original Revision: https://phabricator.services.mozilla.com/D233234

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a8157a8b5454