1897908 - [wpt-sync] Sync PR 46399 - Fix a DCHECK if a block was seen in font-feature-settings.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46399 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46399
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Fix a DCHECK if a block was seen in font-feature-settings.

We cannot Consume() in the streaming parser without first checking that
there's no block involved.

Fixed: 341349803
Change-Id: I0740fe7359f056a561dd1a82f1355b999537945a

Reviewed-on: https://chromium-review.googlesource.com/5554250
WPT-Export-Revision: cc88fc5ffea65e1b13ec1a0e3e80515bb483b56a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=89adfb4e195bdde73ed460f374f724110939a7ad

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cb1343b0ef0
[wpt PR 46399] - Fix a DCHECK if a block was seen in font-feature-settings., a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2cb1343b0ef0