1897956 - Text-Fragments: Set first text directive as `:target`

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Jan Jaeschke [:jjaschke]]

The first text directive needs to be set as :target element.

Comment 1

[Jan Jaeschke [:jjaschke]]

This bug is being worked on in parallel to bug 1897942, which depends on this bug.

Comment 2

[Jan Jaeschke [:jjaschke]]

Try run.

Comment 3

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1897956 - Text Fragments: Set text fragment as `:target`. r=farre!,#dom-core

This patch makes some adjustments to follow the spec more strictly by
separating highlighting a text fragment (ie. adding the ranges to a eTargetText Selection)
from scrolling to it.

Scrolling to the text fragment now follows the steps given in 0 more closely,
in particular now the closest common ancestor of the target range is being used
as :target element.

This change also sets the focus to the start of the first text fragment, as indicated by the spec.
This resets the normal selection on the page.
The wpt test in /css/css-pseudo/target-text-005.html is based on the idea of having a same-doc
text fragment navigation with a selection.
This test fails with this patch applied, because the selection is reset.
It is currently unclear what behavior is correct here, thus the test is kept for now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aab98ffe0ee9
Text Fragments: Set text fragment as `:target`. r=farre,dom-core

Comment 5

[Iulian Moraru]

Backed out 4 changesets (bug 1898321, bug 1897942, bug 1897956) for causing multiple failures.

• Push with failures

• Failure log for build bustages

• Failure log for crashtest failures

• Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16203f0a9251
Text Fragments: Set text fragment as `:target`. r=farre,dom-core

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/16203f0a9251