1897964 - Support startLine, startColumn, endLine, and endColumn query parameters in `Debugger.findScripts`

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

SourceActor._findDebuggeeScripts in DevTools performs the following:

1. findScripts to list all scripts for given source
2. filter out all non-outer-most scripts
3. traverse all child scripts and find scripts that matches given line and column

this is almost what findScripts itself provides with query, except that it only supports single line.
Adding start/end line/column query parameters can replace the !forBreakpointPositions case of _findDebuggeeScripts.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Add 'start' and 'end' query params to findScripts() r=ochameau,arai!

It's simpler to require that 'start' and 'end' be both present than to define
what happens when only one or the other is present. Based on current DevTools
usage, this should be fine.

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Add 'start.column' and 'end.column' query params to findScripts() r=ochameau,arai!

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Require 'start.line' >= 'end.line' r=ochameau,arai!

In the check for the 'line' property, 'lineEnd' needs to be set to 'line'
because 'line' is implemented as 'start.line' and 'end.line' having the same
value.

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Extract ScriptQuery::parseLineColumnObject() r=ochameau,arai!

To improve readability of parseQuery()

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Require displayUrl/url/source with start/end r=ochameau,arai!

Comment 6

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Correct error messages for start/end case r=ochameau,arai!

Comment 7

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Extract parsePositiveNumber() r=ochameau,arai!

Comment 8

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Document findScripts() new query parameters r=ochameau,arai!

Comment 9

[Bryan Thrall [:bthrall]]

Attachment: Bug 1897964 - Precisely check start column in findScripts() r=ochameau,arai!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e4673119a7b
Add 'start' and 'end' query params to findScripts() r=arai
https://hg.mozilla.org/integration/autoland/rev/8cc4773cf657
Add 'start.column' and 'end.column' query params to findScripts() r=arai
https://hg.mozilla.org/integration/autoland/rev/004ee290b7a5
Require 'start.line' >= 'end.line' r=arai
https://hg.mozilla.org/integration/autoland/rev/4c97b411c7bf
Extract ScriptQuery::parseLineColumnObject() r=arai
https://hg.mozilla.org/integration/autoland/rev/897f9534b4b6
Require displayUrl/url/source with start/end r=arai
https://hg.mozilla.org/integration/autoland/rev/4dd56efa4143
Correct error messages for start/end case r=arai
https://hg.mozilla.org/integration/autoland/rev/b0727ea04c48
Extract parsePositiveNumber() r=arai
https://hg.mozilla.org/integration/autoland/rev/80e2abc3001d
Document findScripts() new query parameters r=arai
https://hg.mozilla.org/integration/autoland/rev/f120ce31576f
Precisely check start column in findScripts() r=arai

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6e4673119a7b
https://hg.mozilla.org/mozilla-central/rev/8cc4773cf657
https://hg.mozilla.org/mozilla-central/rev/004ee290b7a5
https://hg.mozilla.org/mozilla-central/rev/4c97b411c7bf
https://hg.mozilla.org/mozilla-central/rev/897f9534b4b6
https://hg.mozilla.org/mozilla-central/rev/4dd56efa4143
https://hg.mozilla.org/mozilla-central/rev/b0727ea04c48
https://hg.mozilla.org/mozilla-central/rev/80e2abc3001d
https://hg.mozilla.org/mozilla-central/rev/f120ce31576f