1898003 - [wpt-sync] Sync PR 46405 - Revert "Update enablement approach for sec-ch-width tests"

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46405 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46405
Details from upstream follow.

Philip Rogers <[e-mail]> wrote:

Revert "Update enablement approach for sec-ch-width tests"

This reverts commit 0cc26e2b517e84e599540c2f13260726c7c6c159.

Reason for revert: Spec was updated to use http-equiv after all:
https://github.com/WICG/client-hints-infrastructure/issues/159

Original change's description:

Update enablement approach for sec-ch-width tests

There are some higher-level interop/spec issues with how to enable
sec-ch-width. This patch switches the tests to use name="Delegate-CH",
which is per-spec [1], as well as sending the Accept-CH header.

[1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo

Bug: 335630145
Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
Commit-Queue: Philip Rogers \<[e-mail]>
Reviewed-by: Traian Captan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Reviewed-on: https://chromium-review.googlesource.com/5555162
WPT-Export-Revision: 1ccaa81b1359992ef2365d068f306734766068e6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 46405 applied with additional changes from upstream: 8648c0beaab6a46f2ea835f80763613b69cbce5d, b70defdd6adc5eb0d836e28c1adec76e2097c9e6, 678333d2f3c6f341151b6ce84bfeb6e56cd93394, 7c62bf27bf7342891e158bbee008e09d69402c87, fc48c21d274e7db39d8d1053ac795ce20fa392c5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=99935fcbfc88696377bf6b358277226e6528b332

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL : 3
TIMEOUT: 1

Chrome

OK : 4
PASS : 2
FAIL : 2

Safari

OK : 3
FAIL : 3
TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /client-hints/sec-ch-width-auto-sizes-001.https.html [wpt.fyi]
  • Sec-CH-Width is set for lazy auto sizes: FAIL (Chrome: FAIL, Safari: FAIL)
• /client-hints/sec-ch-width-auto-sizes-002.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
• /client-hints/sec-ch-width-auto-sizes-003.https.html [wpt.fyi]
  • Sec-CH-Width is set for lazy auto sizes: FAIL (Chrome: FAIL, Safari: FAIL)
• /client-hints/sec-ch-width.https.html [wpt.fyi]
  • Sec-CH-Width should be set: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c0e8471bd66
[wpt PR 46405] - Revert "Update enablement approach for sec-ch-width tests", a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9c0e8471bd66