1898031 - Debugger breakpoints should switch back to main stack when on suspendable code

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[Ryan Hunt [:rhunt]]

Our debuggable code using baseline generates handlers for breakpoints which call out to the Debugger API. That API can lead to arbitrary code running. If our debuggable code is running on a suspendable stack, this could lead to JS code running unexpectedly.

This is very similar to bug 1898029.

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1898031 - Debugger breakpoints should switch back to main stack. r?rhunt

Comment 2

[Phabricator Automation]

Comment on attachment 9407965 [details]
Bug 1898031 - Debugger breakpoints should switch back to main stack. r?rhunt

Revision D214001 was moved to bug 1898032. Setting attachment 9407965 [details] to obsolete.

Comment 3

[Yury Delendik (:yury)]

Attachment: Bug 1898031 - Fix JIT activation binding in DebuggerFrame. r?jandem

Depends on D214001

Comment 4

[Phabricator Automation]

Comment on attachment 9418229 [details]
Bug 1898031 - Fix JIT activation binding in DebuggerFrame. r?jandem

Revision D218246 was moved to bug 1898032. Setting attachment 9418229 [details] to obsolete.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:yury, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Yury Delendik (:yury)]

Attachment: Bug 1898031 - Neglect suspendable stack roots on shutdown. r?iain

Comment 7

[Phabricator Automation]

Comment on attachment 9421586 [details]
Bug 1898031 - Neglect suspendable stack roots on shutdown. r?iain

Revision D220575 was moved to bug 1915677. Setting attachment 9421586 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ecdbd0d0e0d
Debugger breakpoints should switch back to main stack. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/a15c00d85b41
Fix JIT activation binding in DebuggerFrame. r=jandem

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ WasmPI.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/22ba881d768516d2a44c65831c521145dc7fffa8

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/js/src/wasm/WasmPI.cpp:703:3: error: use of undeclared identifier 'CallImportData'

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42a59cca5fad
Debugger breakpoints should switch back to main stack. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/7f5c95da844a
Fix JIT activation binding in DebuggerFrame. r=jandem

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/42a59cca5fad
https://hg.mozilla.org/mozilla-central/rev/7f5c95da844a

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1898031) for causing failures in test_wasm_jspi_profiler.js CLOSED TREE

This started to perma fail on this merge

https://hg.mozilla.org/integration/autoland/rev/c6fe661ddb030b53a79608a7b674be6741f0eb28

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f1191ffa393
Debugger breakpoints should switch back to main stack. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/d48408e0b29e
Fix JIT activation binding in DebuggerFrame. r=jandem

Comment 14

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/8f1191ffa393
https://hg.mozilla.org/mozilla-central/rev/d48408e0b29e