Closed Bug 1898065 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 46413 - Correct implementation of calc-size() interpolation rules.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 46413 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46413
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Correct implementation of calc-size() interpolation rules.

I believe I initially implemented these before the spec was written (or
before I was aware that it was). This updates the interpolation rules
to follow https://drafts.csswg.org/css-values-5/#interp-calc-size plus
the clarifications in https://github.com/w3c/csswg-drafts/issues/10220 .

This doesn't implement the IACVT (invalid at computed value time) aspect
of the clarification in https://github.com/w3c/csswg-drafts/issues/10220
and therefore adds both TODO comments and failing tests. (The tests are
useful to check for lack of crashes; when I first wrote them they did
crash and I needed to fix the crashes.)

Bug: 313072
Change-Id: Ia9903bd138c3afb58ef12da45171920d28de8fa6
Reviewed-on: https://chromium-review.googlesource.com/5546294
WPT-Export-Revision: 6ef53a12eb00cbecf9af2c6f22021a8587dd9a81

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Safari on GitHub CI Total 3 tests and 842 subtests ## Status Summary ### Firefox `OK` : 3 `FAIL`: 2013 ### Safari `OK` : 3 `FAIL`: 2013 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=55781c8ad954dc7feb8e58379ecd8ed085369c2c) [GitHub PR Head](https://wpt.fyi/results/?sha=d4f5eac6579eae7045f8474c69d94a7171a5b005&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=d4f5eac6579eae7045f8474c69d94a7171a5b005&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb2871de4223 [wpt PR 46413] - Correct implementation of calc-size() interpolation rules., a=testonly https://hg.mozilla.org/integration/autoland/rev/c61f89ad9b04 [wpt PR 46413] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: