1898096 - Introduce Contrast Control Settings

Status: NEW

(Firefox :: Disability Access, enhancement)

Description

[Eitan Isaacson [:eeejay]]

The colors section in preferences has been around in one form or another since early web days. It was originally meant to change the colors used in web pages, and precedes CSS. It is very uncommon in on the web today to encounter unstyled content. The ability to change the default colors without high contrast mode does not offer a good experience. Let's rededicate this section to contrast control and offer a straightforward way for users to toggle high contrast and tune it to their needs.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: WIP: Bug 1898096 - Replace color settings with "contrast control".

This patch changes the backing prefs by removing
browser.display.use_system_colors and relying on the tristate offered
by browser.display.document_color_use. This simplifies the color
decision tree.

The UI changes are a rough draft of what the preferences could look
like.

Comment 2

[Eitan Isaacson [:eeejay]]

Attached above is a WIP. I'm curious if you think this is approach is worthy and something I should refine. To get a quick idea of what I did, I would just look at PreferenceSheet.cpp, the doc changes also give a high level overview. You can also try it :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

So not opposed to this in principle, but this changes our behavior on Linux and macOS to default to system colors, which I don't think it'll be web compatible. In particular, on light mode, Canvas should be white by default and CanvasText black, otherwise you risk silly compatibility issues...

Comment 4

[Eitan Isaacson [:eeejay]]

The browser.* color prefs need to be rededicated to HCM exclusively. we should not read those in non HCM mode. we can't use system colors in non-hcm because of Canvas/CanvasText quirks in MacOS. We also cannot use standins because they do not respect system theming for things like accent color. I propose we use a subset of the standins for fg/bg/link/visited.

I refactored PreferenceSheet::Prefs::LoadColors to have 3 branches for color loading

1. no-hcm OR use standins: Use the standin colors for text/bg and link/visited. This changes the current behavior in windows where those colors are retrieved from the system even in non-hcm mode. i don't think this is an issue.
2. hcm explicitly on: use pref colors
3. hcm on via OS settings: use system colors

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I think I'd expect HCM explicitly on to use system colors? At least when in high contrast mode...

Comment 6

[Eitan Isaacson [:eeejay]]

When I say "hcm explicitly on" I mean turning on HCM in Firefox's settings, regardless of OS settings. So in that case we use Firefox's pref colors. If the firefox HCM settings are in "auto", and the OS has HCM, use the system colors.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Yeah, but if the OS has HCM, and HCM is explicitly on, then we should probably still use system colors?

Comment 8

[Eitan Isaacson [:eeejay]]

Maybe a better description of these options is "Auto", "Off" and "Custom". The last one turns on HCM explicitly with colors customized in the browser. This allows users finer grained control over the palette. A use case for that would be Mac or Linux users who get a sub-optimal palette from the OS's HCM and want to use a better one in the browser, or a Windows HCM user who might want finer grained control for web content.

Just like right now, Linux and Mac would have "Off" by default, and Windows "Auto".

Comment 9

[Morgan Reschenberg [:morgan]]

I'm a fan of this :) thanks for working on it !

Comment 10

[MarjaE]

Newer versions of MacOS reworked the system contrast settings.

Increase contrast now takes light colors, and lightens them more. So if you needed to make outlines, edges, etc. bolder and more visible, it makes them fainter and eventually invisible.

I don't think Firefox should require certain system contrast settings.

Comment 11

[Eitan Isaacson [:eeejay]]

(In reply to MarjaE from comment #10)

Newer versions of MacOS reworked the system contrast settings.

Increase contrast now takes light colors, and lightens them more. So if you needed to make outlines, edges, etc. bolder and more visible, it makes them fainter and eventually invisible.

I don't think Firefox should require certain system contrast settings.

The change here allows you to control the contrast settings and colors in Firefox regardless of system palette and preferences. The idea being that this is a very subjective area and web content can behave in all kinds of ways so the user needs better control than simply the OS settings.