1898122 - Crash in [@ nsRefreshDriver::AddStyleFlushObserver]

Status: RESOLVED DUPLICATE of bug 1897322

(Core :: Layout, defect)

Description

[BugBot [:suhaib / :marco/ :calixte]]

Crash report: https://crash-stats.mozilla.org/report/index/244c02bb-3173-4f60-8a92-0a0590240517

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!IsStyleFlushObserver(aPresShell)) (Double-adding style flush observer)

Top 10 frames of crashing thread:

0  xul.dll  nsRefreshDriver::AddStyleFlushObserver  layout/base/nsRefreshDriver.h:186
1  xul.dll  mozilla::PresShell::DoObserveStyleFlushes  layout/base/PresShell.cpp:10227
1  xul.dll  mozilla::PresShell::ObserveStyleFlushes  layout/base/PresShell.h:568
1  xul.dll  mozilla::PresShell::EnsureStyleFlush  layout/base/PresShellInlines.h:57
1  xul.dll  mozilla::PresShell::Init  layout/base/PresShell.cpp:924
1  xul.dll  mozilla::dom::Document::CreatePresShell  dom/base/Document.cpp:6956
2  xul.dll  nsDocumentViewer::InitPresentationStuff  layout/base/nsDocumentViewer.cpp:703
3  xul.dll  nsDocumentViewer::Show  layout/base/nsDocumentViewer.cpp:2080
4  xul.dll  mozilla::RefPtrTraits<nsIDocumentViewer>::AddRef  mfbt/RefPtr.h:48
4  xul.dll  nsCOMPtr<nsIDocumentViewer>::nsCOMPtr  xpcom/base/nsCOMPtr.h:387

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-05-17
• Process type: Content
• Is startup crash: No
• Has user comments: No
• Is null crash: Yes - 1 out of 2 crashes happened on null or near null memory address

By analyzing the backtrace, the regression may have been introduced by a patch [1] to fix Bug 1895870.

[1] https://hg.mozilla.org/mozilla-central/rev?node=cfeff20ff5fb

:emilio, since you are the author of the potential regressor, could you please take a look?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

I believe this is bug 1897322.