1898124 - [wpt-sync] Sync PR 46420 - Change the input format semantics for TextMetrics::getSelectionRects()

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46420 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46420
Details from upstream follow.

Andres Ricardo Perez <[e-mail]> wrote:

Change the input format semantics for TextMetrics::getSelectionRects()

Update how the end index works for getSelectionRects from being
an inclusive limit on both sides, i.e. [start, end], to being exclusive
for the end limit, i.e. [start, end).

This way, we match the index semantics of the underlying
Font::SelectionRectForText() method that is used to calculate the
rects.

Bug: 341213359
Change-Id: I1a09bc256c9f04ae3ae974a587c3e732aa003a74
Reviewed-on: https://chromium-review.googlesource.com/5553293
WPT-Export-Revision: 473805d6a9551476b2bb5188571dbe99315fa7dc

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 46420 applied with additional changes from upstream: 12f8a9095c895763d4165d93c80f04ae9bcd32a7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a42c87b2d0a8853ffb384310b6cc9dc7e9dd45e6

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 8
FAIL: 8

Chrome

OK : 8
PASS: 3
FAIL: 5

Safari

OK : 8
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/offscreen/text/2d.text.measure.selection-rects-baselines.tentative.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() works correctly with textBaseline.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/element/text/2d.text.measure.selection-rects-baselines.tentative.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() works correctly with textBaseline.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/text/2d.text.measure.selection-rects-baselines.tentative.worker.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() works correctly with textBaseline.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/element/text/2d.text.measure.selection-rects-exceptions.tentative.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() throws when using invalid indexes.: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/text/2d.text.measure.selection-rects.tentative.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() matches its DOM equivalent.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/text/2d.text.measure.selection-rects-exceptions.tentative.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() throws when using invalid indexes.: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/text/2d.text.measure.selection-rects-exceptions.tentative.worker.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() throws when using invalid indexes.: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/text/2d.text.measure.selection-rects.tentative.html [wpt.fyi]
  • Check that TextMetrics::getSelectionRects() matches its DOM equivalent.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36067e531920
[wpt PR 46420] - Change the input format semantics for TextMetrics::getSelectionRects(), a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/36067e531920