Closed Bug 1898214 Opened 4 months ago Closed 3 months ago

bakemall.jp - Items are overlapped (relies on magic <input type=number> min / max sizing behavior).

Categories

(Core :: Layout: Form Controls, defect)

Firefox 128
Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox126 --- wontfix
firefox127 --- wontfix
firefox128 --- verified
firefox129 --- verified

People

(Reporter: azlata, Assigned: emilio)

References

()

Details

Attachments

(4 files, 2 obsolete files)

Environment:
Operating system: Windows 10
Firefox version: Firefox 126.0/128.0a1 (2024-05-21)

Steps to reproduce:

  1. Access https://bakemall.jp/store/aab71dcd-c00a-4eb7-a22b-4a48c2f603a1?date=2024-05-30T07%3A00%3A00%2B09%3A00
  2. You might be prompted to choose a date
  3. scroll through the page
  4. Try to add items

Expected Behavior:
The quantities of the items can be changed without issues.

Actual Behavior:
The characters, buttons and fields for entering quantities all overlap, making it impossible to input correctly.

Notes:

  • Reproduces regardless of the status of ETP
  • Reproduces in Firefox Nightly, Firefox Release
  • Does not reproduce in Chrome

Created from https://github.com/webcompat/web-bugs/issues/137268

OS: Unspecified → Windows 10
Hardware: Unspecified → Desktop
Version: unspecified → Firefox 128
Attached video 22.05.2024_11.37.36_REC.mp4 β€”
Component: Site Reports → Layout: Flexbox
Product: Web Compatibility → Core

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Attached file semi-reduced.html β€”
Attachment #9403227 - Attachment is obsolete: true
Attached file reduced test-case β€”

This is just about the auto size of the number input, apparently... Chrome seems to do something where the min / max values influence the auto size, somehow?

Chrome behaves the same as Firefox if I remove the min="" and max="" attributes... Ugh

Component: Layout: Flexbox → Layout: Form Controls

WebKit logic is here.

Blink is here, which looks basically the same (so, probably comes from WebKit).

Summary: bakemall.jp - Items are overlapped → bakemall.jp - Items are overlapped (relies on magic <input type=number> min / max sizing behavior.
Summary: bakemall.jp - Items are overlapped (relies on magic <input type=number> min / max sizing behavior. → bakemall.jp - Items are overlapped (relies on magic <input type=number> min / max sizing behavior).
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd09151a1c46
Implement min/max-derived sizing for <input type=number>. r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46632 for changes under testing/web-platform/tests

Backed out for causing OS X wpt failures in transform-input-014.html.

Flags: needinfo?(emilio)
Upstream PR was closed without merging
Attachment #9405490 - Attachment description: Bug 1898214 - Implement min/max-derived sizing for <input type=number>. r=smaug,#layout → Bug 1898214 - Implement min/max-derived sizing for <input type=number>. r=smaug
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fdc398eba16
Implement min/max-derived sizing for <input type=number>. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Flags: needinfo?(emilio)
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)

This is a long-standing bug so probably not worth uplifting.

Flags: needinfo?(emilio)
QA Whiteboard: [qa-128b-p2]
No longer regressions: 1902249

Reproducible on a 2024-05-22 Nightly build on Windows 10.
Verified as fixed on Firefox 128.0 and Firefox Nightly 129.0a1 on Windows 10, Ubuntu 22, macOS 14.

QA Whiteboard: [qa-128b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: