Don't fire selectionchange if there is one pending
Categories
(Core :: DOM: Editor, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(1 file)
This is a rather surprising recent change to the spec.
https://github.com/w3c/selection-api/issues/170
But I think the behavior is reasonable, assuming it is web compatible.
A patch coming, but haven't yet pushed it to try
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Comment 2•1 year ago
•
|
||
With no implementation PRs? Editing WG really needs proper PR templates. (Sent https://github.com/w3c/clipboard-apis/pull/215)
|
|
Assignee | |
Comment 3•1 year ago
|
||
It landed in a bit weird way. No proper reasoning for the change and Apple was reviewing an Apple pr basically
https://github.com/w3c/selection-api/pull/172
|
|
||
Comment 4•1 year ago
|
||
That's not a "bit weird" but exactly how https://github.com/w3c/clipboard-apis/pull/197 went, except now it's Apple. Both are Editing WG specs, we shouldn't keep it this way. I hope https://github.com/w3c/clipboard-apis/pull/215 can start changing this.
|
||
Updated•1 year ago
|
|
||
Comment 6•1 year ago
|
||
Backed out for causing bc failures @ devtools/client/inspector/fonts/test/browser_fontinspector_reveal-in-page.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/205d54ee1e526a4c4b4755939c320070e25fa051
|
|
Assignee | |
Updated•1 year ago
|
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
|
||
Comment 9•1 year ago
|
||
Lot of improvements on React and React-Redux type benchmarks of SP2 (and potentially SP3).
Short update : 43% improvement on React-Redux-TodoMVC/Adding100Items/Async
38% improvement on React-TodoMVC/Adding100Items/Async
|
||
Comment 10•1 year ago
|
||
(In reply to Pulsebot from comment #7)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6632631a15ec
Don't fire selectionchange if there is one pending, r=masayuki
Perfherder has detected a browsertime performance change from push 6632631a15ec669479862233871777772e5dcf7e.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
|---|---|---|---|---|---|
| 6% | speedometer React-TodoMVC/Adding100Items | macosx1400-64-shippable-qr | fission webrender | 18.41 -> 17.26 | Before/After |
| 6% | speedometer React-TodoMVC/Adding100Items | macosx1400-64-shippable-qr | fission webrender | 18.40 -> 17.26 | Before/After |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 516
For more information on performance sheriffing please see our FAQ.
|
|
||
Comment 11•1 year ago
|
||
Tons of huge (40%-50%) and smaller improvements from this change on sub-tests of SP2 and sp3.
Perfherder has detected a browsertime performance change from push 6632631a15ec669479862233871777772e5dcf7e.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
|---|---|---|---|---|---|
| 49% | speedometer React-Redux-TodoMVC/Adding100Items/Async | linux1804-64-shippable-qr | fission webrender | 6.51 -> 3.31 | Before/After |
| 47% | speedometer React-TodoMVC/Adding100Items/Async | linux1804-64-shippable-qr | fission webrender | 6.28 -> 3.36 | Before/After |
| 43% | speedometer React-Redux-TodoMVC/Adding100Items/Async | windows10-64-shippable-qr | fission webrender | 4.98 -> 2.86 | Before/After |
| 42% | speedometer3 TodoMVC-React-Redux/Adding100Items/Async | linux1804-64-shippable-qr | fission webrender | 7.25 -> 4.21 | Before/After |
| 41% | speedometer React-TodoMVC/Adding100Items/Async | macosx1400-64-shippable-qr | fission webrender | 2.44 -> 1.45 | Before/After |
| ... | ... | ... | ... | ... | ... |
| 2% | speedometer3 TodoMVC-React-Complex-DOM/total | windows10-64-shippable-qr | fission webrender | 89.18 -> 87.28 | Before/After |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 516
For more information on performance sheriffing please see our FAQ.
Description
•