1898356 - "go back one page" arrow (button) remains white (instead of grey) after clearing "browsing & download history"

Status: ASSIGNED

(Toolkit :: Data Sanitization, defect, P3)

Description

[Dan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:126.0) Gecko/20100101 Firefox/126.0

Steps to reproduce:

1. visit https://www.mozilla.org/en-US/firefox/new/
2. on that page, click on "Download options and other languages" (below the blue download button)
3. Now go to "History", "Clear Recent History...", select "Everything" and only tick "Browsing & download history". Then click "Clear Now".

Actual results:

previous page (https://www.mozilla.org/en-US/firefox/new/) is cleared from history as expected, but the "Go back one page" back-arrow remains clickable. (Nothing happens when clicking on it though, as expected)

Expected results:

Back arrow should turn grey (and unclickable) the moment the history is cleared.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Harshit Sohaney [:hsohaney]]

It looks like it turns grey if you switch tabs and come back, this might just be some sort of refresh issue. Will add it our backlog! Thanks for reporting this

Comment 3

[Diego Ciudad Real Escalante [:descalante]]

Hello, can I take this bug?

Comment 4

[Harshit Sohaney [:hsohaney]]

Absolutely! Let us know if you need any help

Comment 5

[Harshit Sohaney [:hsohaney]]

Switching owners based on assignment in the open source club meeting.

Comment 6

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 7

[Mauro B]

Heya! I already have a fix for this bug. Can I get assigned to it? Thanks!

Comment 8

[Mauro B]

Attachment: Bug 1898356 - Fixed navigation toolbar buttons not updating after clearing 'browsing & download history'

Comment 9

[Manuel Bucher [:manuel]]

Hi, thats great! @Harshit do you mind reviewing and mentoring with this patch? If not you can also bounce back and set me as mentor.

Comment 10

[Harshit Sohaney [:hsohaney]]

Happy to mentor this!

Comment 11

[Mauro B]

Attachment: WIP: Bug 1898356 - Fixed navigation toolbar buttons not updating after clearing 'browsing & download history'

Comment 12

[Mauro B]

Attachment: WIP: Bug 1898356 - Fixed back and forward buttons not being disabled when having multiple windows

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 14

[chase.philpot]

Attachment: Bug 1898356 - "go back one page" arrow (button) turns grey after clearing "browsing & download history" and is no longer clickable. r?hsohaney!

Comment 15

[chase.philpot]

Since Harshit is no longer at Mozilla and I see that you have fixed other bugs in the Data Sanitization component, could you review or recommend a reviewer? Thank you in advance!

Comment 16

[Manuel Bucher [:manuel]]

Hi, Harshit is still active and can review your patch. (I can also review if he doesn't find time this week, @Harshit do you think you'll find time soon to review this patch?)

I can give you a quick comment on the process of submitting: Please update the original revision (D233227) with your current patch and abandone all other revisions (D235512, D235513, D257167) by clicking on the action "Abandon revision" at the bottom of phabricator.

To do so, make sure the last line of the commit message is

Differential Revision: https://phabricator.services.mozilla.com/D233227

and then run moz-phab for uploading your revision. (I've updated the revision so that it'll accept the patch from the new git repository)

mossop and harshit will be get your patch into their review queue automatically then.

Comment 17

[Harshit Sohaney [:hsohaney]]

I'm gonna review it soon (most probably over the weekend)!

Comment 18

[Manuel Bucher [:manuel]]

Thank you! @chase It would be great if you could update your patches until then (as described in comment #16) to make it clear which one needs review.

Comment 19

[chase.philpot]

@Manuel I have abandoned revision D257167, but I cannot abandon revisions D235512, D235513 because I do not have permission to do so. I also followed your instructions: made a commit with my patch and ensured that the last line of the Differential Revision matched D233227, ran moz-phab and then got the following response:

"Phabricator Error: Validation errors: You can not request review of this revision because you are not the author of the revision or in the proper permissions group."

Please let me know what I can do to move this patch forward. Thank you in advance!

Comment 20

[Harshit Sohaney [:hsohaney]]

You can't update that revision since it was made by a different contributor. You should create a patch like you previously had. I can handle abandoning the other open patches that are no longer active!

Sorry about the confusion there.

Comment 21

[Mauro V [:cheff]]

Those patches where done by me but I lost access to my old account... Terribly sorry, I dont think I can abandon the patches from here

Comment 22

[chase.philpot]

Attachment: Bug 1898356 - go back one page arrow (button) turns grey after clearing browsing & download history. r=hsohaney

Comment 23

[chase.philpot]

@Harshit, I have resubmitted the patch. Could you please review / confirm that this patch addresses the issue and is on track for landing? Thank you.

Comment 24

[Harshit Sohaney [:hsohaney]]

Yep, I'll take a look soon, it's been a bit of a busy week!

Comment 25

[chase.philpot]

Hi @Harshit I submitted a test that needs to be reviewed. Thank you in advance!

Comment 26

[Harshit Sohaney [:hsohaney]]

I'll take a look sometime this week! Haven't forgotten, just swamped a little

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/54aaf25ea02a
https://hg.mozilla.org/integration/autoland/rev/8d9f16b0eded
go back one page arrow (button) turns grey after clearing browsing & download history. r=hsohaney

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07691799127b
https://hg.mozilla.org/integration/autoland/rev/0819c87986c0
Revert "Bug 1898356 - go back one page arrow (button) turns grey after clearing browsing & download history. r=hsohaney" for causing bc failures @ browser_purgehistory_clears_sh.js

Comment 29

[amarc]

Backed out for causing bc failures @ browser_purgehistory_clears_sh

• Backout link
• Push with failures
• Failure Log

Comment 30

[chase.philpot]

Attachment: Bug 1898356 - "go back one page" arrow (button) remains white (instead of grey) after clearing "browsing & download history". r?hsohaney

Comment 31

[chase.philpot]

Attachment: Bug 1898356 - "go back one page" arrow (button) remains white (instead of grey) after clearing "browsing & download history". r?hsohaney

Comment 32

[chase.philpot]

Attachment: Bug 1898356 - "go back one page" arrow (button) remains white (instead of grey) after clearing "browsing & download history". r?hsohaney!