1898361 - Add ability to disable WNP via whatsNewPage nimbus feature

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Shane Hughes [:aminomancer]]

We currently have the ability to run experiments with multiple content variants of a whats new page, but we also want to run experiments with e.g. 90% treatment, 10% control. But we can't do that right now because the feature only supports changing the WNP URL. We need a new variable that will disable the feature, like this:

variables:
  disableWNP:
    description: >-
      Completely block what's new pages bundled with updates. Used to compare
      no-WNP control branches to WNP treatment branches.
    type: boolean
    setPref:
      branch: user
      pref: startup.homepage_override_nimbus_disable

And then check the pref in BrowserContentHandler and bail out of showing a WNP if it's enabled.

Comment 1

[Hanna Alemu [:hanna_a]]

Attachment: WIP: Bug 1898361 - Add ability to disable WNP via whatsNewPage nimbus feature

Comment 2

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1898361 - Add ability to disable WNP via whatsNewPage nimbus feature r=aminomancer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6829ed75952b
Add ability to disable WNP via whatsNewPage nimbus feature r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers

Comment 4

[Cristina Horotan [:chorotan]]

Backed out changeset 6829ed75952b (bug 1898361) for causing build bustage at NimbusMessagingControllerTest.kt

Backout: https://hg.mozilla.org/integration/autoland/rev/5324082d4382820d3461e1411f2cdcc716c5403e

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6829ed75952b274f93b9e817bf2a889358761462

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=464950846&repo=autoland&lineNumber=1772
https://treeherder.mozilla.org/logviewer?job_id=464950888&repo=autoland&lineNumber=25124

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/158f4c78fb00
Add ability to disable WNP via whatsNewPage nimbus feature r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers CLOSED TREE

Comment 6

[Cristina Horotan [:chorotan]]

Re-landing because it was backed out the wrong patch.

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/158f4c78fb00